fix(migrate): complete vp migrate for existing Vite+ projects#1821
Open
jong-kyung wants to merge 13 commits into
Open
fix(migrate): complete vp migrate for existing Vite+ projects#1821jong-kyung wants to merge 13 commits into
jong-kyung wants to merge 13 commits into
Conversation
Finish core script, import, and tsconfig type rewrites when vite-plus is already installed but legacy Vite signals remain. Add regression coverage matching the manual migration reproduction with package manager overrides.
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
jong-kyung
force-pushed
the
fix/migrate-partial-vite-plus
branch
from
1d85af2 to
822a576
Compare
jong-kyung
force-pushed
the
fix/migrate-partial-vite-plus
branch
from
962e6bc to
e42e2fb
Compare
jong-kyung
changed the title
Collaborator
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Member
|
@codex review |
fengmk2
added
test: e2e
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62aaf17b34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Complete existing Vite+ package manager bootstrap checks so partial migrations do not leave unresolved pnpm catalogs, npm override conflicts, or missing pnpm peer rules.
Keep existing Vite+ bootstrap catalog usage limited to paths that also define catalog entries, and cover pnpm/yarn monorepo edge cases.
Limit existing Vite+ direct dependency cleanup to the npm override conflict path so other package managers keep their package specs untouched during bootstrap completion.
Collaborator
Author
|
@fengmk2 I fixed the Codex review feedback. Could you please take another look? 🙇♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite-plusinpackage.jsonas an installation signal, not a migration-complete signal.ESLint/Prettier migration, and active legacy hook migration.
hooks/agent/editor setup unless explicitly requested.
Validation
pnpm -F vite-plus snap-test-global migration-already-vite-pluspnpm -F vite-plus snap-test-global migration-partially-installed-vite-pluspnpm -F vite-plus snap-test-global migration-eslint-lint-staged-mjsvp check --fix packages/cli/src/migration/bin.ts packages/cli/src/migration/migrator.ts packages/cli/src/migration/report.ts packages/cli/src/migration/__tests__/migrator.spec.tsvp test run packages/cli/src/migration/__tests__/migrator.spec.tscloses #1817