fix(cli): surface git output when initial commit fails#1819
Open
fengmk2 wants to merge 2 commits into
Open
Conversation
The warning always suggested checking git user.name/user.email even when the commit failed for other reasons (e.g. a failing pre-commit hook). Show the actual git commit output instead, and add a snap test covering the failure path.
✅ Deploy Preview for viteplus-preview canceled.
|
The bundled org fixture (mock registry, manifest, tarball) is not needed to exercise the initial-commit failure path. The builtin template runs fully offline and shrinks the fixture to steps.json plus the hook.
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b83cfd2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the initial commit fails during
vp create --git, the warning always says "Check your git user.name/user.email config" even when the failure has nothing to do with git identity (e.g. a failing pre-commit hook). The actual git error is discarded, making the failure hard to diagnose.Fix
createInitialCommitnow returns the combined stdout/stderr ofgit commit, and both call sites print it under theInitial commit failedwarning. When identity is the real problem, git's own message is shown verbatim.Adds a snap test (
create-git-commit-fail) that scaffolds the builtinvite:monorepotemplate offline and forces a deterministic pre-commit hook failure viaGIT_CONFIG_*env vars, locking in the surfaced output.Note
Low Risk
CLI-only UX and return-type change for initial commit; no auth or data-path changes, covered by a snap test.
Overview
When
vp create --gitcannot create the initial commit, the CLI no longer assumes a user.name/user.email problem.createInitialCommitnow returnssuccessplus combinedgit commitstdout/stderr, and both create flows print that text under a short Initial commit failed warning.A new snap test (
create-git-commit-fail) forces a failing pre-commit hook viacore.hooksPathand asserts the hook message appears while.gitis still created.Reviewed by Cursor Bugbot for commit b83cfd2. Configure here.