Skip to content

ci: pin cargo-zigbuild to git rev to fix aarch64-musl link failure #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 4 commits into from
Jun 11, 2026
+8 −4
Merged

ci: pin cargo-zigbuild to git rev to fix aarch64-musl link failure #1815

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ef87df
ci: pin cargo-zigbuild to git rev to fix aarch64-musl link failure
fengmk2 Jun 11, 2026
9b46935
ci: run release build matrix on toolchain and build pipeline changes
fengmk2 Jun 11, 2026
c2582f3
ci: move toolchain build check into ci.yml
fengmk2 Jun 11, 2026
7f7a5e5
ci: drop toolchain build check job for now
fengmk2 Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/actions/build-upstream/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ runs:
id: cache-key
shell: bash
run: |
echo "key=napi-binding-v3-${INPUTS_TARGET}-${RELEASE_BUILD}-${DEBUG}-${VERSION}-${NPM_TAG}-${{ hashFiles('packages/tools/.upstream-versions.json', 'Cargo.lock', 'crates/**/*.rs', 'crates/*/Cargo.toml', 'packages/cli/binding/**/*.rs', 'packages/cli/binding/Cargo.toml', 'Cargo.toml', '.cargo/config.toml', 'packages/cli/package.json', 'packages/cli/build.ts', 'packages/cli/tsdown.config.ts') }}" >> $GITHUB_OUTPUT
echo "key=napi-binding-v3-${INPUTS_TARGET}-${RELEASE_BUILD}-${DEBUG}-${VERSION}-${NPM_TAG}-${{ hashFiles('packages/tools/.upstream-versions.json', 'rust-toolchain.toml', 'Cargo.lock', 'crates/**/*.rs', 'crates/*/Cargo.toml', 'packages/cli/binding/**/*.rs', 'packages/cli/binding/Cargo.toml', 'Cargo.toml', '.cargo/config.toml', 'packages/cli/package.json', 'packages/cli/build.ts', 'packages/cli/tsdown.config.ts') }}" >> $GITHUB_OUTPUT
env:
INPUTS_TARGET: ${{ inputs.target }}

Expand Down Expand Up @@ -81,11 +81,15 @@ runs:
with:
version: 0.15.2

# Rust nightly-2026-06-10 passes --fix-cortex-a53-843419 to the linker for
# aarch64-linux targets, which zig cc rejects. The filter for this arg
# (rust-cross/cargo-zigbuild#452) is merged but unreleased, so install from
# the pinned git commit. TODO: revert to taiki-e/install-action once
# cargo-zigbuild > 0.22.3 is released.
- name: Install cargo-zigbuild (musl)
if: steps.cache-restore.outputs.cache-hit != 'true' && contains(inputs.target, 'musl')
uses: taiki-e/install-action@4bc351f7f2614e48088386e2a0ad917ca3a7e4ba # v2.81.5
with:
tool: cargo-zigbuild
shell: bash
run: cargo install --locked --git https://github.com/rust-cross/cargo-zigbuild --rev 7e791b4be71b9870e0abccedf7885486803cd923 cargo-zigbuild

# NAPI builds - only run on cache miss (slow, especially on Windows)
# Must run before vite-plus TypeScript builds which depend on the bindings
Expand Down
Loading