Skip to content

fix(cli): reject git options inside existing monorepos#1788

Merged
fengmk2 merged 7 commits into
voidzero-dev:mainfrom
jong-kyung:fix/create-generator-skip-git-init
Jun 8, 2026
Merged

fix(cli): reject git options inside existing monorepos#1788
fengmk2 merged 7 commits into
voidzero-dev:mainfrom
jong-kyung:fix/create-generator-skip-git-init

Conversation

@jong-kyung

Copy link
Copy Markdown
Collaborator

Summary

Reject --git and --no-git when using vp create vite:generator.

vite:generator adds a generator package to an existing monorepo, so git initialization options do not apply. The command now fails early with a clear message when either option is provided, while the normal vp create vite:generator flow continues to skip git initialization.

@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview ready!

Name Link
🔨 Latest commit 31b9106
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a26be557289660008c63198
😎 Deploy Preview https://deploy-preview-1788--viteplus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@jong-kyung jong-kyung self-assigned this Jun 8, 2026
@jong-kyung jong-kyung force-pushed the fix/create-generator-skip-git-init branch from 1e4d68f to b943c83 Compare June 8, 2026 09:27
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b943c83858

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/create/bin.ts
@jong-kyung jong-kyung marked this pull request as ready for review June 8, 2026 09:51
@jong-kyung jong-kyung requested a review from fengmk2 June 8, 2026 09:51
@jong-kyung jong-kyung marked this pull request as draft June 8, 2026 10:04
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@jong-kyung jong-kyung marked this pull request as ready for review June 8, 2026 10:08
@fengmk2

fengmk2 commented Jun 8, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/create/bin.ts Outdated
@jong-kyung jong-kyung changed the title fix(cli): reject git options for vite:generator fix(cli): reject git options inside existing monorepos Jun 8, 2026
@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: create-e2e Run `vp create` e2e tests labels Jun 8, 2026
@fengmk2 fengmk2 merged commit 7a3defe into voidzero-dev:main Jun 8, 2026
134 of 135 checks passed
@jong-kyung jong-kyung deleted the fix/create-generator-skip-git-init branch June 9, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants