chore(deps): update rust to nightly-2026-06-10#1725
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
|
wait for voidzero-dev/vite-task#420 |
renovate
Bot
force-pushed
the
renovate/rust-1.x
branch
from
8684c37 to
f32a462
Compare
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/rust-1.x
branch
from
f32a462 to
e7148bb
Compare
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/rust-1.x
branch
from
e7148bb to
94d9212
Compare
renovate
Bot
changed the title
The new nightly's clippy added unused_async_trait_impl, which fires in upstream rolldown crates without a `[lints]` table (rolldown_plugin_lazy_compilation).
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
fengmk2
reviewed
Jun 10, 2026
fengmk2
approved these changes
Jun 10, 2026
fengmk2
added a commit
that referenced
this pull request
Jun 10, 2026
The nightly-2026-06-10 bump (#1725) added allows for the new clippy lints (`unused_async_trait_impl`, `useless_borrows_in_formatting`) to the CI clippy command only, so local `just lint` fails on the vendored rolldown crates (they have no `[lints]` table, so workspace-level allows cannot reach them). Fix: move the `-A` flags into the `just lint` recipe and have CI run `just lint`, so there is no second copy of the clippy command to keep in sync. Also apply the same reuse to the test jobs: the test matrix and test-musl jobs now run `just test` instead of duplicating the package-enumerating cargo test command. The windows test recipe gains `RUST_MIN_STACK` to match what CI previously set via env. Notes: - The old CI clippy command omitted `--workspace` while the justfile has it; the root manifest is a virtual workspace, so lint coverage is identical. - The test matrix job installs `just` via setup-rust tools (same pattern as upgrade-deps.yml); the musl job installs it from the Alpine community repo. - On the Windows runner, `just test` now uses the `[windows]` recipe (powershell) instead of the bash command; it additionally sets `__COMPAT_LAYER=RunAsInvoker`, which is harmless on CI. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Changes only affect CI orchestration and local/CI command parity; no application or security logic is modified. > > **Overview** > CI **test**, **test-musl**, and **lint** now delegate to **`just test`** and **`just lint`** instead of inlining duplicate `cargo test` / `cargo clippy` commands. **`just`** is installed in those jobs (via `setup-rust` tools or Alpine `apk`). > > The **justfile** becomes the single source of truth: **`lint`** picks up the same clippy `-A` allows that CI used to carry alone (so local **`just lint`** matches CI after newer toolchain lints), and **`test`** documents the all-`crates/*` plus **`vite-plus-cli`** package list. The Windows **`test`** recipe now sets **`RUST_MIN_STACK=8388608`** like CI did via env. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 2f1d702. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
fengmk2
added a commit
that referenced
this pull request
Jun 11, 2026
Cross-compilation (zig/musl, napi-cross) only runs in the label-gated release build matrix, so toolchain bumps like #1725 merge without ever exercising those paths. Add a workflow that runs the full matrix when a PR touches rust-toolchain.toml, .cargo/config.toml, or the build pipeline itself. Also include rust-toolchain.toml in the NAPI binding cache key so a toolchain bump invalidates native binaries built with the old toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
nightly-2026-05-24→nightly-2026-06-10Configuration
📅 Schedule: (in timezone Asia/Shanghai)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.