Repository navigation
vp migrate --full asks to set up pre-commit hooks even when they're already configured #3096
Description
Description
In a project that already has Vite+ hooks (.vite-hooks/pre-commit, core.hooksPath=.vite-hooks/_), vp migrate --full still asks:
◇ Set up pre-commit hooks to run formatting, linting, and type checking with auto-fixes?
Yes / No
It defaults to Yes and doesn't say hooks already exist. Answering No sounds like it might disable them, though it doesn't.
The agent prompt in the same run detects the existing file and offers Append/Skip:
› Agent instructions already exist at AGENTS.md.
Append
› Skip: Leave existing file unchanged
promptGitHooks() doesn't check hasExistingViteHooksPolicy(), which setupGitHooks() already uses to leave the hook as it is.
Suggested solution
When existing Vite+ hooks are detected, either:
- Skip the prompt and log
Git hooks already configured, or - Say so in the prompt and offer Keep/Skip, like the agent prompt does.
Additional context
vp v1.3.0- Related: voidzero-dev/vite-plus#2459
Validations
- Read the Contributing Guidelines.
- Confirm this request is for Vite+ itself and not for Vite, Vitest, tsdown, Rolldown, or Oxc.
- Check that there isn't already an issue requesting the same feature.
Metadata
Metadata
Assignees
Type
Fields
Priority
None yet
Activity
0froq commentedon Oct 18, 2026
I have a fix ready for this, following the second option: when existing Vite+ hooks are detected (and
--hooks/--no-hooksisn't passed), the prompt becomes a Keep/Skip select mirroring theAGENTS.mdone, listing the detected hooks, e.g. "Git hooks already configured in .vite-hooks/ (pre-commit, commit-msg)". Keep (default) leaves them unchanged; Skip leaves the hooks setup untouched. Non-interactive behavior is unchanged. Tests included.Branch: https://github.com/0froq/vite-plus/tree/fix/migrate-existing-hooks-prompt
I also have the first option (skip the prompt and log) ready if you'd prefer that. Happy to open a PR with whichever you like.
fengmk2 commentedon Oct 19, 2026
@0froq send the pr please 👍
fix(migrate): show existing git hooks and offer Keep/Skip
fix(migrate): skip git hooks setup when already configured (voidzero-…