[WIP][ci skip] New package: zed-1.1.6#59813
[WIP][ci skip] New package: zed-1.1.6#59813JudahJL wants to merge 1 commit intovoid-linux:masterfrom
Conversation
|
dupllicate #58659 |
|
@Nizarjh I apologize for the duplicate pr. |
u can use my template and patches for your own) |
58e12fe to
abf6b69
Compare
|
u need also change binary name from zed to smth with patch. u can look how i made this in my pr. But my pacth is not actual to new version. so do your own for this version of zed |
@Nizarjh I don't need to use that patch. I'm renaming the executable at do_install stage. There's also an additional check in the check build CI/CD that ensures no name conflicts occur in the executables(which successfully passes) |
oh i see. Sorry :) |
| pkgname=zeditor | ||
| version=0.231.1 | ||
| revision=1 | ||
| archs="x86_64 aarch64" |
There was a problem hiding this comment.
| archs="x86_64 aarch64" | |
| archs="x86_64* aarch64*" |
There was a problem hiding this comment.
Didn't compile successfully on musl versions locally
There was a problem hiding this comment.
Then that is a merge blocker, there is no reason it shouldn't work with musl.
There was a problem hiding this comment.
Because of dependencies not existing in one of the musl version. For details, I'll let you know when I get home
There was a problem hiding this comment.
x86_64-linux-musl:
ERROR: Could not find package 'cross-x86_64-linux-musl'
=> ERROR: cross-x86_64-linux-musl-0.37_5: cannot be built, it's currently broken; see the build log:
=> ERROR: cross-x86_64-linux-musl-0.37_5: Can't build crosstoolchain to itself
aarch64-musl:
error: failed to run custom build command for `prost-build v0.9.0`
Caused by:
process didn't exit successfully: `/builddir/zed-0.231.1/target/release/build/prost-build-b23121bcf79afb3f/build-script-build` (exit status: 101)
--- stderr
thread 'main' (12773) panicked at /host/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/prost-build-0.9.0/build.rs:105:10:
Failed to find the protoc binary. The PROTOC environment variable is not set, there is no bundled protoc for this platform, and protoc is not in the PATH
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
There was a problem hiding this comment.
livekit/rust-sdks#409
Previously used only for Android builds; now an unused leftover from an earlier commit.
There was a problem hiding this comment.
I'm more interested in what the issue is or if it works rather than if upstream officially supports it. If we would only build packages where the upstream officially tests musl, the musl repo would be almost empty.
There was a problem hiding this comment.
undefined reference to `__vsnprintf_chk'
undefined reference to `__pthread_create'
undefined reference to `__memcpy_chk'
undefined reference to `__fdelt_chk'
undefined reference to `fopen64'
undefined reference to `open64'
undefined reference to `mmap64'
There was a problem hiding this comment.
This downloads binaries linked against glibc during build.
There was a problem hiding this comment.
i get that. havent been able to solve that yet
ec019c1 to
9640597
Compare
|
im sorry for closing and opening the pr. renaming the branch messed it up |
0161cbf to
277edca
Compare
|
zed also needs cargo-about 8.2.0 (which is currently orphaned) to embed dependencies licenses into the binary. cargo-about can be easily fixed(tried locally), but cargo-about@latest is 8.4.0 as of now |
|
skipping CI/CD till im able to compile libwebrtc locally which should fix the musl builds |
5f113cc to
4b9151a
Compare
|
https://zed.dev/releases/stable great news I guess. |
18aa21d to
6aaea31
Compare
Signed-off-by: JudahJL <judahlegy@gmail.com>
Testing the changes
New package
Local build testing