Enhance Settings layout and add customizable Stop button behavior#188
Enhance Settings layout and add customizable Stop button behavior#188MysticILD wants to merge 4 commits into
Conversation
|
Thanks for your effort on this PR! I really appreciate your work on optimizing the Settings layout and implementing custom playback behaviors. However, the proposed three-stage/two-stage/instant options don't quite match what I have planned for the project's playback control. I apologize that I didn't detail this in the TODO earlier, so let me clarify the behavior I'm aiming for. Instead of choosing between different fixed modes, I want to implement a smarter dynamic behavior for the Stop and Pause controls, driven by a Playback Marker (temporary start position). Here is the exact behavior I'd like to achieve: 1. Playback Marker Behavior
2. Stop Button Behavior
3. Pause Button Behavior
I think this logic will feel much more intuitive for aligned with current DAWs (FL, ACE). Would you be open to refactoring the PR? If you feel this is too far from your original design or don't have time to implement it, no worries at all! Just let me know, and I can close this PR and implement this behavior myself later. (We could still keep your Settings layout optimization if you'd like to split it into a separate PR!) Thanks again for your awesome contribution. |
Isn’t this the exact same logic in this PR? When you press Stop, it defaults to returning you to the starting position of playback, then to the beginning of the currently selected UPart, and finally to tick 0. Or am I missing something? |
|
Hello @vocoder712, I've refactored the PR to implement the dynamic Stop button behavior you outlined, but with a few adjustments: I've fixed the logic to be closer to what you requested (Playback Marker -> UPart -> 0). However, I kept the Stop Button Behavior settings (the different modes) just for customization purposes, in case users still prefer the old ways. I actually tried implementing the Play button setting you suggested (Condition A: returning to the marker when starting playback from a paused state). However, I ended up reverting it because it doesn't really make sense for a mobile app workflow. On mobile, users generally expect Play to simply resume from where they paused or from where they just tapped on the timeline. |
This PR optimizes the Settings page layout for better readability (specifically for LTR languages) and introduces a customizable Stop button behavior feature with three user-selectable options: