improve check command and solver problem reporting#577
Open
oliverkurth wants to merge 2 commits into
Open
Conversation
Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
Signed-off-by: Oliver Kurth <oliver.kurth@broadcom.com>
7dbb1d2 to
6908d55
Compare
sshedi
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves
tdnf's solver problem reporting to provide full dependency chains for conflicts, making it significantly easier to debug broken dependencies.Previously,
tdnfusedsolver_findproblemrulewhich only surfaced the "leaf" problem (e.g.,package expect is disabledorconflicting requests), omitting the context of which package actually required it.Changes Included:
SolvReportProblemsto usesolver_findallproblemrules, traversing and printing the entire chain of dependency rules that lead to a solver failure.--verboseflag. Standard output prints the original leaf error alongside a hint:Please retry with --verbose to see detailed solver rules.--skipconflictsBehavior: Addressed an issue where purely conflict-based rules were hidden, but the root install job rule remained, causing unexplainableconflicting requestsoutput. The entire problem block is now correctly suppressed if it is fundamentally a conflict problem.pytestcoverage intest_install.pyto verify the fallback error hint and the detailed reporting behavior.Example