✨ Add contract readiness signal to VM Operator's VirtualMachine and generic VM controllers - #1911
Merged
aruneshpa merged 1 commit intoSep 8, 2026
Conversation
…eneric VM controllers The generic kube-vm.io VirtualMachine contract requires every provider to expose overall readiness at a fixed status path, so the core controller can mirror it without any provider-specific code. VM Operator's VirtualMachine had no such summary signal, so an adopted generic object could report the VM as fully created and reachable yet stay stuck at "Waiting" forever. Add status.ready and an InfrastructureReady condition to the VirtualMachine API, computed in status reconciliation from whether the VM has converged to its desired power state and, if powered on, has reported an address. Named InfrastructureReady rather than Ready because the existing Ready condition is already reserved for the result of a configured guest readiness probe, and is deliberately left unset when no probe is configured; reusing it would have collided with that behavior. Wire the kube-vm.io core controller's status contract reader to the new condition type, and update its tests and fixtures accordingly. Testing Done: - Creating a KubeVM VM with minimal specs (VM class, stroageClass, bootDisk, powerState) and an empty VM Operator VM spec now works - The VM Operator VM gets owned by KubeVM, status is correctly reflected up the stack to KubeVM.
aruneshpa
deleted the
minor/controller-changes-and-readiness-status-demo-ready
branch
September 8, 2026 04:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
The generic kube-vm.io VirtualMachine contract requires every provider to expose overall readiness at a fixed status path, so the core controller can mirror it without any provider-specific code. VM Operator's VirtualMachine had no such summary signal, so an adopted generic object could report the VM as fully created and reachable yet stay stuck at "Waiting" forever.
Add status.ready and an InfrastructureReady condition to the VirtualMachine API, computed in status reconciliation from whether the VM has converged to its desired power state and, if powered on, has reported an address. Named InfrastructureReady rather than Ready because the existing Ready condition is already reserved for the result of a configured guest readiness probe, and is deliberately left unset when no probe is configured; reusing it would have collided with that behavior.
Wire the kube-vm.io core controller's status contract reader to the new condition type, and update its tests and fixtures accordingly.
Testing Done:
Please add a release note if necessary: