fix e2e failure (test PR) - #1907
Draft
anwithaun-1 wants to merge 1 commit into
Draft
Conversation
Contributor
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
RCA: This test intentionally deletes the VM while it still has two attached snapshots (one a memory snapshot), to verify they get garbage-collected. vCenter's Destroy_Task on a VM with outstanding snapshots consolidates the delta disks and memory-snapshot file as part of the same task, which takes noticeably longer than deleting a snapshot-free VM. The test was polling with the shared default/wait-virtual-machine-deletion interval (5m/3s), which isn't budgeted for that consolidation overhead — the VM deletion succeeded, just a couple of minutes past the 5-minute window, causing a spurious failure.
Fix:
Added a spec-scoped interval override, vm-snapshot/wait-virtual-machine-deletion: ["10m", "5s"], in wcp.yaml and kind.yaml, following the existing register-vm-restore-disk-only precedent for giving one spec more headroom without loosening the timeout for every other caller.
Extended VerifyVMDeleted to accept an *IntervalOptions param (same pattern as WaitForBootDiskPVC) so callers can opt into a spec-specific interval.
Only the "Delete vm" step in the VM-SNAPSHOT test opts into the longer budget; all other callers pass nil and are unaffected (verified via go build/go vet and by tracing each call site).
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: