🐛 E2E fix: Wait for disk promotion to complete if IP not available after timeout. - #1898
Open
aniket-deole wants to merge 1 commit into
Open
🐛 E2E fix: Wait for disk promotion to complete if IP not available after timeout. #1898aniket-deole wants to merge 1 commit into
aniket-deole wants to merge 1 commit into
Conversation
Contributor
Minimum allowed line rate is |
aniket-deole
changed the title
aakashchan
reviewed
Sep 4, 2026
| Fail(fmt.Sprintf("Timed out waiting for VirtualMachine %s to get an IPv4 address", vmName)) | ||
| } | ||
|
|
||
| By(fmt.Sprintf("VirtualMachine '%s/%s' IP not ready yet; wait for disk promotion in case it's the cause", ns, vmName)) |
Contributor
There was a problem hiding this comment.
Sometimes DiskPromotion tasks from other VMs would keep VMware tools down. Suggestion is, let's run it irrespective and wait for disk promotion to complete before proceeding to the next VM.
This will ensure that the infra is not overloaded in uncontrolled manner.
Contributor
Author
There was a problem hiding this comment.
Are you suggesting to increase the timeout from 5m to 10m for all cases?
If that's so, is checking for disk promo needed?
aniket-deole
marked this pull request as ready for review
September 4, 2026 15:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Wait for disk promotion to complete if IP not available after timeout. Does not wait fail on disk promotion, if disk promotion is not completed, it runs another round to check if IP would be available.
Which issue(s) is/are addressed by this PR?
Fixes # 4155
Are there any special notes for your reviewer:
Please add a release note if necessary: