🐛 Fix vm-publish e2e test race condition and diagnostics - #1894
Open
anwithaun-1 wants to merge 2 commits into
Open
🐛 Fix vm-publish e2e test race condition and diagnostics#1894anwithaun-1 wants to merge 2 commits into
anwithaun-1 wants to merge 2 commits into
Conversation
anwithaun-1
changed the title
anwithaun-1
force-pushed
the
topic/anwitha/vm-publish-request-fixes
branch
from
September 4, 2026 05:25
f223323 to
d75ccd0
Compare
Contributor
Minimum allowed line rate is |
anwithaun-1
marked this pull request as ready for review
September 4, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Race condition: The test calls
GetVirtualMachineMOID()on a shared source VM immediately after issuing a publish request, with no wait for VM placement. The helper is documented as requiring the VM to be placed (status.uniqueID populated), which happens during VM creation reconciliation. Under load or slow placement, the MOID would still be empty.Fixes:
GetVirtualMachineMOID()(single-shot) withWaitForVirtualMachineMOID()(Eventually-polled) before reading vCenter properties, matching the pattern used elsewhere in the test suite.deployedVMNameto Context scope, assign it at each VM deploy site, and dump it on failure so diagnostics capture the actual failed VM.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
vmop-4159
Are there any special notes for your reviewer:
Please add a release note if necessary: