Repository navigation
Fix Negotiator parser and own the custom runtime - #2
Merged
spenceralbrecht merged 1 commit intoOct 25, 2026
Merged
Conversation
spenceralbrecht
deleted the
security/json-api-vendored-negotiator-20261025
branch
October 25, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinned custom Negotiator fork retains the language-parser regex affected by GHSA-7mc5-chhp-fmc3. This change brings its small MIT runtime into this repository, applies the exact upstream parser fix, and removes the external Git dependency. Custom detailed media-type objects, language behavior and the original 250 tests are preserved. Provenance and license are included; this is internal source, not a renamed official package.
Both source callers use the internal runtime. The build and package allowlist deliver it and its declarations at the compiled path. A real packed-package consumer installs offline from the exact reviewed dependency closure, then exercises the public entry, real media negotiation, language regression and declarations without falling back to the checkout. The other 532 public lock nodes, library version, Node >=18.20.8 contract and TypeScript 4.9 tooling remain unchanged.
Validation before publication: Node 18.20.8 and 24.22.1 each pass build/lint, 180 source units, 180 compiled units, all 250 fork tests, three parser/compatibility controls, nine installer guards and the isolated packed consumer. Existing tooling/runtime controls also pass. Local checks ran with OS network denial and an EPERM control. The original vulnerable parser fails the bounded adversarial regression; the patched parser passes. The same tarball integrity is produced on both runtimes.
The existing two Linux jobs retain their 15/10-minute ceilings and read-only permissions. Actual hosted qualification, complete isolated MongoDB integration and CodeQL are checked on this head. The original fork suite retains three historical pending tests alongside 250 passing; the complete database suite retains five historical pending tests alongside 314 passing. No new skips are introduced. The fixed body-parser 1.20.9 exception remains exact and guarded. No registry publication, production API 2.15.7-fork replacement, alert dismissal or comprehensive vendored-source security clearance is claimed.