Skip to content

Fix Negotiator parser and own the custom runtime - #2

Merged
spenceralbrecht merged 1 commit into
masterfrom
security/json-api-vendored-negotiator-20261025
Oct 25, 2026
Merged

spenceralbrecht merged 1 commit into
masterfrom
security/json-api-vendored-negotiator-20261025

Conversation

@spenceralbrecht

@spenceralbrecht spenceralbrecht commented Oct 25, 2026 •

Copy link
Copy Markdown

The pinned custom Negotiator fork retains the language-parser regex affected by GHSA-7mc5-chhp-fmc3. This change brings its small MIT runtime into this repository, applies the exact upstream parser fix, and removes the external Git dependency. Custom detailed media-type objects, language behavior and the original 250 tests are preserved. Provenance and license are included; this is internal source, not a renamed official package.

Both source callers use the internal runtime. The build and package allowlist deliver it and its declarations at the compiled path. A real packed-package consumer installs offline from the exact reviewed dependency closure, then exercises the public entry, real media negotiation, language regression and declarations without falling back to the checkout. The other 532 public lock nodes, library version, Node >=18.20.8 contract and TypeScript 4.9 tooling remain unchanged.

Validation before publication: Node 18.20.8 and 24.22.1 each pass build/lint, 180 source units, 180 compiled units, all 250 fork tests, three parser/compatibility controls, nine installer guards and the isolated packed consumer. Existing tooling/runtime controls also pass. Local checks ran with OS network denial and an EPERM control. The original vulnerable parser fails the bounded adversarial regression; the patched parser passes. The same tarball integrity is produced on both runtimes.

The existing two Linux jobs retain their 15/10-minute ceilings and read-only permissions. Actual hosted qualification, complete isolated MongoDB integration and CodeQL are checked on this head. The original fork suite retains three historical pending tests alongside 250 passing; the complete database suite retains five historical pending tests alongside 314 passing. No new skips are introduced. The fixed body-parser 1.20.9 exception remains exact and guarded. No registry publication, production API 2.15.7-fork replacement, alert dismissal or comprehensive vendored-source security clearance is claimed.

@spenceralbrecht
spenceralbrecht merged commit 97cdc44 into master Oct 25, 2026
4 checks passed
@spenceralbrecht
spenceralbrecht deleted the security/json-api-vendored-negotiator-20261025 branch October 25, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant