Skip to content

Repair dependency security and qualify supported Node runtimes - #1

Merged
spenceralbrecht merged 8 commits into
masterfrom
security/json-api-latest-ci-qualification-20261025
Oct 25, 2026
Merged

spenceralbrecht merged 8 commits into
masterfrom
security/json-api-latest-ci-qualification-20261025

Conversation

@spenceralbrecht

@spenceralbrecht spenceralbrecht commented Oct 25, 2026 •

Copy link
Copy Markdown

Repairs the runtime and development dependency graph, including the exact body-parser 1.20.9 fix, while preserving the original lint policy and conservative handling of custom Mongoose errors. Adds request-stream regression controls and replaces obsolete Node 8/10 CircleCI configuration with bounded GitHub qualification.

Compatibility changes: Node >=18.20.8 and TypeScript >=4.9 are now explicit requirements. Node 24.22.1 runs the complete development toolchain; Node 18.20.8 retains build, lint and runtime compatibility checks. Package publication and downstream consumer adoption require separate decisions.

Validation before push: full build/lint, 180 source units, 180 compiled units and emitted public entry passed on both Node versions. Node 24 tooling and Node 18 parser/lint controls passed under OS-level network denial. A fresh credential-free installation verified all 533 installed manifest versions and the ten approved body-parser files. Public install guards reject altered versions, private/authenticated registry destinations and changed Git source identity.

Hosted Linux qualification passed on b5ce50c: both Node versions passed build/lint, 180 source units and 180 compiled units; the complete disposable MongoDB integration selection passed with 314 passing, 5 unchanged pending, 0 failing. Listener and service-container cleanup passed. A one-line legacy test correction preserves both HTTP requests and their assertions while using only callback completion. Two isolated compiler-child tests now give their parent 15 seconds while retaining each child's existing 10-second limit. The two standard Ubuntu jobs are capped at 15 and 10 minutes and use a digest-pinned MongoDB 7.0.45 service without production credentials.

Existing CodeQL default setup remains enabled. Both analysis execution and the separate security gate passed on b5ce50c, with no new alerts in code changed by this PR. The three earlier helper findings were fixed without suppression: installed-file verification now opens once with no-follow, checks and reads the same descriptor with bounded size and expected hashes, and always closes it; parser probes use fixed static imports. Nine installer controls cover changed bytes, symlinks, pathname replacement, growth and descriptor cleanup. All eleven parser stream controls remain intact. This result is not a claim that the repository has no existing alerts.

The recorded offline public advisory corpus reported 0 critical and 0 high findings for the 532 public registry nodes. That is a dated source scan, not a fresh scan or complete clearance: the pinned custom Git Negotiator source remains separately unverified. No package registry publication or deployment is part of this PR.

Comment thread .github/scripts/install-public.cjs Fixed
Comment thread test/body-parser-security.cjs Fixed
Comment thread test/body-parser-security.cjs Fixed
@spenceralbrecht
spenceralbrecht merged commit b675bdd into master Oct 25, 2026
4 checks passed
@spenceralbrecht
spenceralbrecht deleted the security/json-api-latest-ci-qualification-20261025 branch October 25, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants