Repository navigation
Repair dependency security and qualify supported Node runtimes - #1
Merged
spenceralbrecht merged 8 commits intoOct 25, 2026
Merged
Conversation
spenceralbrecht
deleted the
security/json-api-latest-ci-qualification-20261025
branch
October 25, 2026 08:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the runtime and development dependency graph, including the exact body-parser 1.20.9 fix, while preserving the original lint policy and conservative handling of custom Mongoose errors. Adds request-stream regression controls and replaces obsolete Node 8/10 CircleCI configuration with bounded GitHub qualification.
Compatibility changes: Node >=18.20.8 and TypeScript >=4.9 are now explicit requirements. Node 24.22.1 runs the complete development toolchain; Node 18.20.8 retains build, lint and runtime compatibility checks. Package publication and downstream consumer adoption require separate decisions.
Validation before push: full build/lint, 180 source units, 180 compiled units and emitted public entry passed on both Node versions. Node 24 tooling and Node 18 parser/lint controls passed under OS-level network denial. A fresh credential-free installation verified all 533 installed manifest versions and the ten approved body-parser files. Public install guards reject altered versions, private/authenticated registry destinations and changed Git source identity.
Hosted Linux qualification passed on
b5ce50c: both Node versions passed build/lint, 180 source units and 180 compiled units; the complete disposable MongoDB integration selection passed with 314 passing, 5 unchanged pending, 0 failing. Listener and service-container cleanup passed. A one-line legacy test correction preserves both HTTP requests and their assertions while using only callback completion. Two isolated compiler-child tests now give their parent 15 seconds while retaining each child's existing 10-second limit. The two standard Ubuntu jobs are capped at 15 and 10 minutes and use a digest-pinned MongoDB 7.0.45 service without production credentials.Existing CodeQL default setup remains enabled. Both analysis execution and the separate security gate passed on
b5ce50c, with no new alerts in code changed by this PR. The three earlier helper findings were fixed without suppression: installed-file verification now opens once with no-follow, checks and reads the same descriptor with bounded size and expected hashes, and always closes it; parser probes use fixed static imports. Nine installer controls cover changed bytes, symlinks, pathname replacement, growth and descriptor cleanup. All eleven parser stream controls remain intact. This result is not a claim that the repository has no existing alerts.The recorded offline public advisory corpus reported 0 critical and 0 high findings for the 532 public registry nodes. That is a dated source scan, not a fresh scan or complete clearance: the pinned custom Git Negotiator source remains separately unverified. No package registry publication or deployment is part of this PR.