fix: allow aube install scripts with npm 12 - #147
Merged
Conversation
jdx
marked this pull request as draft
August 15, 2026 14:01
Contributor
Author
|
going to fix aube so it actually works under npm 12 instead |
jdx
changed the title
jdx
marked this pull request as ready for review
August 16, 2026 20:54
lukekarrys
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@endevco/aubewhen the benchmark setup installs it with npm 12Root cause
npm 12 blocks dependency lifecycle scripts by default.
@endevco/aubeuses a preinstall script to select and install its platform-specific native binary, so the existing plain global install completed without creating anaubeexecutable and the benchmark harness excluded it.Aube 1.41.0 now supports npm 12's allowlist propagation correctly. Explicitly allowing only
@endevco/aubelets its required installer run while retaining npm 12's default-deny policy for other packages.@darcyclarke could you take a look?
Validation
bash -n scripts/setup.shshellcheck scripts/setup.sh@endevco/aube@latestinto an isolated prefix with npm 12.0.2 and--allow-scripts=@endevco/aubeAI-assisted — Tool: Codex; model: unavailable; version: unavailable.