Repository navigation
[Refactor] Remove unused runtime helpers - #582
Open
jiangkuaixue123 wants to merge 1 commit into
Open
jiangkuaixue123 wants to merge 1 commit into
jiangkuaixue123 wants to merge 1 commit into
Conversation
Signed-off-by: jiangkuaixue123 <jiangxiaozhou111@163.com>
jiangkuaixue123
requested review from
hsliuustc0106 and
ronenkat
as code owners
November 14, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Unused runtime helpers remained in the production package after the runner migrations. Remove the obsolete microbatch wrapper, DeepSeek attention-builder input isolation helper, unused configuration helpers, and unused connector key export. Move FP8 test-weight generation and runtime class resolution into test helpers.
Issue
No linked issue.
Scope
Implementation Notes
tests/unit/fakes/weights.pyand class resolution throughtests/unit/fakes/runtime.py, including the isolated NPU import script.coerce_extra_int()to fix an existing mypy overload error reproduced on the base revision. Conversion and error handling remain unchanged.Test Plan
.venv/bin/python -m pytest tests/unit -m 'not gpu and not vllm_runtime' -ra.venv/bin/python -m pytest tests/unit/config -o addopts= -qgit diff --check.Test Result
5df63a7203cdb9328d824a27b682e77c7b9928be) and vLLM-Ascendbd42eea01d8312c4df469fabaed45f77a12df4d3.Docs Impact
Update the module design index, Attention runtime and model integration pages, and the review skill's worker/engine references to describe the remaining production paths.
Essential PR Checklist