Replace create_all() with Alembic migrations#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SQLAlchemy
Base.metadata.create_all()startup call with proper Alembic schema migrations, enabling safe, incremental, and reversible database schema changes in production.Motivation
The previous approach used
create_all()during FastAPI lifespan startup to create tables. While convenient for development, this is unsuitable for production:create_all()concurrently)Changes
New files:
Settings)asyncpgimagestable (14 columns, 3 indexes)alembic upgrade headonce before Uvicorn forks workersModified files:
create_all()from lifespan; migrations now run via Docker entrypointENTRYPOINT[2.2.1]entry2.2.0→2.2.1Design decisions
create_all()deployments by checkinginspector.get_table_names()env.pyreads credentials fromSettings(pydantic-settings) at runtimeTesting
ruff) and type-check (mypy) cleanHow to use
Diff stats