ci: speed up the android build (~2 min, no tests removed) - #86
Closed
vitofico wants to merge 1 commit into
Closed
Conversation
The build job ran assembleDebug, test, and lint as three separate ./gradlew invocations (three configuration phases), and test/lint each built BOTH the debug and release variants. CI ships the debug APK and the release variant's compilation is validated by the release job's assembleRelease, so the debug variant is sufficient on the build job. Collapse to a single debug-scoped invocation: ./gradlew assembleDebug testDebugUnitTest lintDebug Keeps every debug unit test, debug lint check, and the APK packaging check; drops only the redundant release-variant unit tests + release lint and two extra configuration phases. ~2 min faster on a ~9 min build (unit tests 146s->~75s, lint 61s->~30s, two fewer daemon/config startups). No tests removed.
Owner
Author
|
Closing — the ~2 min saving isn't worth the added workflow complexity and the release-variant test/lint coverage tradeoff. CI stays as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
buildjob ranassembleDebug,test, andlintas three separate./gradlewinvocations (three configuration phases), andtest/linteach built both the debug and release variants. Collapsed to a single debug-scoped invocation:Why it's safe
assembleDebugpackaging check.releasejob'sassembleReleaseonmain; variant-specific unit tests are virtually never present), plus two redundant Gradle configuration phases.Impact (from a recent build's step timings)
≈ 2 min off the ~9-min build. This PR's own
buildrun demonstrates it.