fix: avoid inlining optimizer hidden sourcemaps (fix #23287) - #23288
Open
szupzj18 wants to merge 2 commits into
Open
fix: avoid inlining optimizer hidden sourcemaps (fix #23287)#23288szupzj18 wants to merge 2 commits into
szupzj18 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The dependency optimizer emits hidden source maps, but optimized dependencies were sent through the normal transform response path.
send()therefore converted the returned map into an inline data URL, making the HTTP response much larger than the optimized file on disk.Change
Serve optimized dependencies with an external
sourceMappingURLthat keeps the browser hash query, and return the post-transform map from the dedicated.mapendpoint. This avoids base64 response bloat while preserving debugger mappings and existing path-traversal sanitization.Validation
.mapendpoint serves the generated mappnpm test-unit packages/vite/src/node/__tests__/optimizer/hiddenSourcemap.spec.ts packages/vite/src/node/__tests__/optimizer/customExtensionBundleClose.spec.tspnpm run test-serve js-sourcemap(9 passed)pnpm exec oxfmt --check ...pnpm exec eslint ...pnpm run buildFixes #23287