fix(create-vite): update moved eslint-react plugin links in generated README - #23284
Merged
bluwy merged 2 commits intoAug 18, 2026
Merged
Conversation
… README The eslint-react repository restructured its plugins into the plugins/ directory, so the old packages/plugins/ paths now return 404. Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
btea
previously approved these changes
Aug 17, 2026
Member
|
Can we update these to npmx links? Like https://npmx.dev/package/eslint-plugin-react-x. Since we mention installing these packages, I think it makes more sense to link to registry pages. |
Link the generated README install hints to the npm registry pages, as requested in review. Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
Contributor
Author
|
Updated the generated README links to the npmx registry pages: Both return 200. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
packages/create-vite/src/index.ts, the generated README for React templates links to the eslint-react plugin directories at the oldpackages/plugins/location:https://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-xhttps://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-domBoth URLs now return 404. The eslint-react repository restructured and the plugins now live under
plugins/, which can be confirmed in the repository tree:https://github.com/Rel1cx/eslint-react/tree/main/plugins/eslint-plugin-react-xhttps://github.com/Rel1cx/eslint-react/tree/main/plugins/eslint-plugin-react-domThis affects every newly scaffolded React project that reads its generated README.
Solution
Update both links to the current
plugins/paths in the template text used to generate the README.Verification
curl -L -o /dev/null -w "%{http_code}"on the old URLs returns404200git diff --checkpasses; only the single template line changes