Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please take a moment to read this. Thank you!
I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author).
If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence.
I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏)
I hold myself to this standard for every PR, regardless of its size.
Summary
A Vite transform hook can spend time on a module and return
undefinedornull. The inspector records that time, but the module summary excludes transforms that return no code. The hook's duration appears in plugin details but is missing from the module's transform and total times. This makes the module appear faster than it is.This change includes every recorded transform when it adds up module timings. The tests cover
undefined,null, unchanged code, changed code, and empty code. They also check the stored results and module sizes.Evidence
Results from the implementation checks:
undefinedandnullcases reported 5ms instead of 1205ms and omitted the slow plugin. The three cases that returned code passed.After: All five cases passed.
pnpm lint,pnpm test --run(356 passed, 2 skipped),pnpm typecheck, andpnpm buildpassed.Merge Danger
Door: Two-way.
Blast Radius: Module-metrics.
Module timing totals and plugin entries now include hooks that ran without returning code.