docs: keep Latest News to product features, never CI/devx/bugs - #1162
Conversation
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe news update flow filters non-feature themes, tests the filter, narrows generation guidance to user-facing features, and replaces the release automation news entry with a data-flow tracing entry. ChangesFeature-only news filtering
Feature-only generation guidance and published content
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/update_news.py`:
- Around line 28-42: Extend NON_FEATURE_THEME and the deterministic
is_feature_theme filtering to recognize Documentation, Tests, Refactors,
Bug-Fix, and Performance, including their relevant plural or punctuation
variants. Add regression cases in test_update_news.py covering each excluded
theme and verify extract_bullets does not pass them through as feature entries.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 6e9094d0-5511-4b90-91bf-363ebd4f6de9
📒 Files selected for processing (5)
.github/workflows/version-bump.ymlNEWS.mdREADME.mdcodebase_rag/tests/test_update_news.pyscripts/update_news.py
Greptile SummaryThis update broadens the Latest News theme filter for maintenance-oriented topics while preserving valid user-facing feature entries. The earlier report that valid feature themes were discarded is disproved: direct execution accepted and prepended both requested feature entries, while rejecting the CI control entry. Confidence Score: 5/5No blocking failure remains. No accepted blocking findings remain. Direct execution confirmed that valid feature themes are retained and inserted into Latest News as intended.
 T-Rex LogsWhat T-Rex did
Reviews (2): Last reviewed commit: "fix: broaden non-feature theme filter an..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
@coderabbitai @greptileai addressed in e5811d5 — broadened the non-feature filter (docs/tests/perf, plural/hyphen spellings), dropped the over-broad |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
git show --stat --oneline e5811d55
git show --format=fuller --find-renames --find-copies -- \
e5811d55 -- scripts/update_news.py codebase_rag/tests/test_update_news.py NEWS.md .github/workflows/version-bump.yml
ast-grep outline scripts/update_news.py --items all
ast-grep outline codebase_rag/tests/test_update_news.py --items allLength of output: 4342 🏁 Script executed: #!/bin/bash
set -euo pipefail
sed -n '18,95p' scripts/update_news.py
sed -n '1,105p' codebase_rag/tests/test_update_news.py
rg -n -C 3 '\b(?:is_feature_theme|extract_bullets)\s*\(' \
scripts/update_news.py codebase_rag/tests/test_update_news.pyLength of output: 11027
The filter now rejects the stated non-feature variants. It also allows feature themes such as I inspected the implementation and focused test assertions. I did not execute tests in the sandbox. ✏️ Learnings added
|
|
1 participant
The "Latest News" section had picked up a Release Automation entry — a tooling/devx item, not a user-facing feature. Latest News should be substantial product features and capabilities only. This removes that entry and prevents the kind from recurring, from every source.
Changes
Release Automationbullet fromNEWS.md; regenerate the README (now shows Ruby Support / Structural Search & Replace / Data-Flow Tracing).NEWS.mdheader — entries are headline features (language support, analysis, querying, graph, integrations); explicitly not CI, developer tooling, release/build automation, refactors, docs, tests, or bug fixes. This governs hand edits too.scripts/update_news.py— a newis_feature_theme()drops any bullet whose theme names non-feature work (automation,release,ci,devx,tooling,refactor,chore,workflow,bump,bug fix, …) before it can reach the README. This is a hard backstop independent of what the AI generator emits. Word-boundary matched so genuine features survive (e.g.Dependency Graphis kept,Dependency Bumpsis dropped).version-bump.yml— "Cover ONLY substantial new user-facing product features … You MUST NOT include CI, developer experience, tooling, build or release automation, refactors, performance work, documentation, tests, dependency bumps, or bug fixes. When in doubt, omit."Tests
test_drops_non_feature_themed_bullets— a fragment mixing Release Automation / CI / Bug Fixes / a real feature yields only the feature.TestIsFeatureTheme— rejects the non-feature themes, accepts real product-feature themes (incl. theDependency GraphvsDependency Bumpsboundary).test_update_news.py: 13 passed. Lint + type-check clean; YAML valid.Summary by CodeRabbit
FLOWS_TOtaint edges across assignments, calls, and I/O sinks in C#, Java, C, and Go.