Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@mburri The CI still fails but locally the build script works 🤷 |
mburri
approved these changes
May 15, 2026
Contributor
mburri
left a comment
There was a problem hiding this comment.
I trggered the build by adding to the changelog - and then deployment on vercel was successfull. That's something that I observed multiple times now after dependency changes: the first deployment will fail - I don't now why.
Afterwards one of the e2e tests failed - and again, rerunning the e2e tests fixed it.
One thing maybe bothers me: the PR title suggests that you updated node-fetch - but I don't see this from any changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates and removes some packages to get rid of vulnerable versions of node-fetch
I took the opportunity to also update two packages which I maintain with Zazuko