Skip to content

build(deps): update node-fetch#2562

Draft
tpluscode wants to merge 8 commits into
mainfrom
deps
Draft

build(deps): update node-fetch#2562
tpluscode wants to merge 8 commits into
mainfrom
deps

Conversation

@tpluscode
Copy link
Copy Markdown
Contributor

@tpluscode tpluscode commented May 14, 2026

This updates and removes some packages to get rid of vulnerable versions of node-fetch

I took the opportunity to also update two packages which I maintain with Zazuko


  • I added a CHANGELOG entry
  • I made a self-review of my own code
  • I wrote tests for the changes (if applicable)
  • I wrote configurator and chart config migrations (if applicable)

@tpluscode tpluscode requested a review from mburri May 14, 2026 15:13
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
visualization-tool Ready Ready Preview, Comment May 15, 2026 1:21pm

Request Review

@tpluscode tpluscode marked this pull request as draft May 14, 2026 15:14
@tpluscode
Copy link
Copy Markdown
Contributor Author

@mburri The CI still fails but locally the build script works 🤷

Copy link
Copy Markdown
Contributor

@mburri mburri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trggered the build by adding to the changelog - and then deployment on vercel was successfull. That's something that I observed multiple times now after dependency changes: the first deployment will fail - I don't now why.

Afterwards one of the e2e tests failed - and again, rerunning the e2e tests fixed it.

One thing maybe bothers me: the PR title suggests that you updated node-fetch - but I don't see this from any changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants