fix(comparison): run verify:claims on spec/V0.8-DECISIONS.md edits, and re-sync EXPERIMENTS.md §11.13's scalefactor cell - #117
Merged
Conversation
verify-claims.ts registers a figure in spec/V0.8-DECISIONS.md, but neither the push nor the pull_request path filter listed that file, so an edit to it alone never ran the gate. Add it to both filters, and name all six gated files in the filter and step comments.
…−0.14% §11.9 and §9.5's re-source table both read −0.14% for the best scalefactor-bands arm; the §11.13 'Deliberately unchanged' table still read −0.13%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Summary
.github/workflows/ci-comparison.yml:verify-claims.tsregisters a figure inspec/V0.8-DECISIONS.md(since fix(spec): re-sync the #102-moved prose figures and bind them in verify:claims #116), but neither thepushnor thepull_requestpath filter listed that file. So a change that edited only that file never ran the gate. This PR addsspec/V0.8-DECISIONS.mdto both filters. It also updates the comment above each filter, and theverify:claimsstep comment, to name all six files the gate reads. The step comment previously said "four files" and left outspec/constants.pyandspec/V0.8-DECISIONS.md.spec/EXPERIMENTS.md: in §11.13's "Deliberately unchanged" table, theNo scalefactor bandscell changes from −0.13% to −0.14%. This matches §11.9 (sweeps/scalefactor-bands.jsonbest arm, −0.14%) and §9.5's re-source table. This document is the source, soverify:claimscannot see this cell. The issue cites line 2911; after fix(spec): re-sync the #102-moved prose figures and bind them in verify:claims #116 the cell is at line 2914.Changed paths
.github/workflows/ci-comparison.ymlspec/V0.8-DECISIONS.mdto both path filters and updates the three commentsspec/EXPERIMENTS.mdValidation
mise run verify:claims: 34 quoted figures across 6 files, all agree.mise run verify:experiments: 1229 bound cells agree (the §11.13 cell is prose-table text, not a bound cell).pathslists now includespec/V0.8-DECISIONS.md.Coverage gaps
verify-claims.ts's register. A future file added to the register can be missed again in the same way. That drift check is out of this issue's scope.Decisions taken
spec/constants.py, which the old comment also left out. The issue asked for the comment to be corrected, and listing only five files would leave it wrong.