Pretty: drop inner parens when CUnary applies to CUnary#110
Open
jkoppel wants to merge 1 commit into
Open
Conversation
`!!x` currently prints as `! (!x)`. The existing inline comment —
-- parens aren't necessary, but look nicer imho
— already acknowledges this is stylistic. Both forms parse to the
same AST.
Originally authored by @dvekeman in 2016 on the downstream
`jkoppel/language-c` fork.
jkoppel
force-pushed
the
pretty-printer-cosmetic
branch
from
c2d3e39 to
95302b4
Compare
jkoppel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!!xcurrently prints as! (!x). The existing inline comment inPretty.hs—— already says the parens are stylistic. This drops them:
!!xstays!!x. Both forms parse to the same AST, so this is purely about source text; happy to close if you prefer the current output.(Split from #109, which is the real AST-round-trip bug.)
Original commit by @dvekeman.