Language.C.Parser.Lexer: accept C23 bool keyword #104
Merged
Conversation
- This requires naming the int128 token correctly in tokenlist.txt. - The #ifdef needs to be restored manually after generation, unfortunately. - CTokFloatN 16 moves around, but stays within the #ifdef - CTokBFloat16 moves around, but stays outside the #ifdef
C23 makes bool a proper keyword and C preprocessors will no longer expand it to `_Bool` which remains a valid alias. This is relatively simple to support and unbreaks a lot of packages that use c2hs with gcc 15 which defaults to -std=c23. Fixes build of Hackage packages hd5-lite, heystone, nfc, regex-rure.
sternenseemann
force-pushed
the
c23-bools
branch
from
96d72cb to
3eeb4a5
Compare
Author
|
typedef enum _eq_bool bool; |
Collaborator
|
Thanks! |
Collaborator
Could you please submit a patch? |
sternenseemann
added a commit
to sternenseemann/language-c
that referenced
this pull request
Mar 11, 2026
The test suite has been failing after visq#104 since language-c would reject `bool` occurring in places where a keyword may not (as would a C compiler/preprocessor). gcc_dg_pre.tar.bz2 contains C preprocessor output generated with older versions of GCC using older versions of the C standard. In particular `bool` is used as a variable name and as a (custom) type name in some of preprocessor outputs. Since the tarball doesn't contain the original C files the output was generated from, I resorted to haphazardly editing the outputs. I made the following modifications: - pr38948.i: removed `typedef unsigned char bool;` - pr37684.i: removed `typedef int bool;` - enum-mode-2.i: renamed `typedef … bool;` to `typedef … my_bool` - Wcxx-compat-2.i: removed `int bool;` declaration
Author
|
#105 Looks like CI doesn't run the full test suite? |
Collaborator
Yeah, I think it does not. I'd welcome a PR fixing this, perhaps as a separate job. |
Bodigrim
pushed a commit
that referenced
this pull request
Mar 14, 2026
The test suite has been failing after #104 since language-c would reject `bool` occurring in places where a keyword may not (as would a C compiler/preprocessor). gcc_dg_pre.tar.bz2 contains C preprocessor output generated with older versions of GCC using older versions of the C standard. In particular `bool` is used as a variable name and as a (custom) type name in some of preprocessor outputs. Since the tarball doesn't contain the original C files the output was generated from, I resorted to haphazardly editing the outputs. I made the following modifications: - pr38948.i: removed `typedef unsigned char bool;` - pr37684.i: removed `typedef int bool;` - enum-mode-2.i: renamed `typedef … bool;` to `typedef … my_bool` - Wcxx-compat-2.i: removed `int bool;` declaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C23 makes bool a proper keyword and C preprocessors will no longer
expand it to
_Boolwhich remains a valid alias. This is relativelysimple to support and unbreaks a lot of packages that use c2hs
with gcc 15 which defaults to -std=c23.
It fixes the build of all Hackage packages that use c2hs and break with GCC 15 (heystone, nfc, regex-rure, hd5-lite) except for
avifwhich requires[[nodiscard]].