Skip to content

🎨 Palette: Added ARIA labels to icon-only buttons #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vireapp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Added ARIA labels to icon-only buttons #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/room/room-client-v2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,7 @@ export function RoomClientV2({ room, user }: RoomClientV2Props) {
size="icon"
onClick={() => setMobileTab("none")}
className="rounded-full"
aria-label="Close mobile tab"
>
<X className="w-6 h-6" />
</Button>
Expand Down Expand Up @@ -1065,6 +1066,7 @@ export function RoomClientV2({ room, user }: RoomClientV2Props) {
variant="secondary"
onClick={copyCode}
className="shrink-0 bg-white/10 hover:bg-white/20 border-0"
aria-label="Copy room code"
>
{copied ? (
<Check className="w-4 h-4 text-emerald-500" />
Expand Down Expand Up @@ -1219,6 +1221,7 @@ export function RoomClientV2({ room, user }: RoomClientV2Props) {
size="icon"
onClick={() => setMobileTab("menu")}
className="text-white hover:bg-white/10 rounded-full"
aria-label="Open mobile menu"
>
<MoreVertical className="w-5 h-5" />
</Button>
Expand Down Expand Up @@ -1562,7 +1565,7 @@ export function RoomClientV2({ room, user }: RoomClientV2Props) {
<div className="absolute right-4 top-24 bottom-24 w-[320px] z-[60] flex flex-col animate-in fade-in slide-in-from-right-10 duration-500 bg-black/80 backdrop-blur-xl border border-white/10 rounded-2xl shadow-2xl overflow-hidden">
<div className="p-4 border-b border-white/5 bg-white/5 flex items-center justify-between shrink-0">
<h2 className="text-lg font-medium text-white">People</h2>
<Button variant="ghost" size="icon" onClick={() => setIsPeopleOverlayOpen(false)} className="h-8 w-8 text-white/50 hover:text-white rounded-full hover:bg-white/10">
<Button variant="ghost" size="icon" onClick={() => setIsPeopleOverlayOpen(false)} className="h-8 w-8 text-white/50 hover:text-white rounded-full hover:bg-white/10" aria-label="Close people overlay">
<X className="w-4 h-4" />
</Button>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/components/room/video-grid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@ export function VideoGrid({
{/* In-Card Controls - Mobile Only (Bottom Bar handles Desktop) */}
<div className="md:hidden absolute bottom-3 left-0 right-0 flex justify-center items-center z-20">
<div className="flex gap-3 p-2 bg-black/60 backdrop-blur-md rounded-full border border-white/10 shadow-xl">
<button onClick={(e) => { e.stopPropagation(); toggleMic(); }} className={cn("p-2 rounded-full transition-all active:scale-95", isMicOn ? "bg-emerald-500 text-white" : "bg-red-500 text-white")}>
<button onClick={(e) => { e.stopPropagation(); toggleMic(); }} className={cn("p-2 rounded-full transition-all active:scale-95", isMicOn ? "bg-emerald-500 text-white" : "bg-red-500 text-white")} aria-label={isMicOn ? "Mute Microphone" : "Unmute Microphone"}>
{isMicOn ? <Mic className="w-5 h-5" /> : <MicOff className="w-5 h-5" />}
</button>
<button onClick={(e) => { e.stopPropagation(); toggleCam(); }} className={cn("p-2 rounded-full transition-all active:scale-95", isCamOn ? "bg-white/10 text-white" : "bg-red-500 text-white")}>
<button onClick={(e) => { e.stopPropagation(); toggleCam(); }} className={cn("p-2 rounded-full transition-all active:scale-95", isCamOn ? "bg-white/10 text-white" : "bg-red-500 text-white")} aria-label={isCamOn ? "Turn Camera Off" : "Turn Camera On"}>
{isCamOn ? <Video className="w-5 h-5" /> : <VideoOff className="w-5 h-5" />}
</button>
<button onClick={(e) => { e.stopPropagation(); toggleScreen(); }} className="p-2 rounded-full bg-white/10 text-white transition-all active:scale-95">
<button onClick={(e) => { e.stopPropagation(); toggleScreen(); }} className="p-2 rounded-full bg-white/10 text-white transition-all active:scale-95" aria-label="Share Screen">
<Monitor className="w-5 h-5" />
</button>
</div>
Expand Down