Skip to content

🎨 Palette: Enhance Navigation & Call Accessibility #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vireapp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Enhance Navigation & Call Accessibility #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions dev_server.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@

> prototype@0.1.0 dev
> next dev --turbo

â–² Next.js 16.1.6 (Turbopack)
- Local: http://localhost:3000
- Network: http://192.168.0.2:3000
- Environments: .env.local

✓ Starting...
âš  The "middleware" file convention is deprecated. Please use "proxy" instead. Learn more: https://nextjs.org/docs/messages/middleware-to-proxy
✓ Ready in 1250ms
â—‹ Compiling /login ...
GET /login 200 in 6.7s (compile: 6.1s, proxy.ts: 7ms, render: 603ms)
GET /features/test-nav 200 in 1919ms (compile: 1577ms, proxy.ts: 39ms, render: 303ms)
GET /features/test-nav 200 in 100ms (compile: 7ms, proxy.ts: 8ms, render: 85ms)
[?25h
1 change: 1 addition & 0 deletions src/components/dashboard-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export function DashboardNav() {
variant="ghost"
size="sm"
asChild
aria-label={item.label}
className={cn(
"relative transition-all duration-300",
isActive
Expand Down
38 changes: 32 additions & 6 deletions src/components/dashboard/call-overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,11 +755,25 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini

{/* Right: Controls */}
<div className="flex items-center gap-2">
<Button variant="ghost" size="icon" className="h-9 w-9 hover:bg-white/10 rounded-full" onClick={toggleMute}>
<Button
variant="ghost"
size="icon"
className="h-9 w-9 hover:bg-white/10 rounded-full"
onClick={toggleMute}
aria-label={isMuted ? "Unmute" : "Mute"}
title={isMuted ? "Unmute" : "Mute"}
>
{isMuted ? <MicOff className="w-4 h-4 text-red-400" /> : <Mic className="w-4 h-4 text-white" />}
</Button>
{type === "video" && (
<Button variant="ghost" size="icon" className="h-9 w-9 hover:bg-white/10 rounded-full" onClick={toggleVideo}>
<Button
variant="ghost"
size="icon"
className="h-9 w-9 hover:bg-white/10 rounded-full"
onClick={toggleVideo}
aria-label={isVideoOff ? "Turn Camera On" : "Turn Camera Off"}
title={isVideoOff ? "Turn Camera On" : "Turn Camera Off"}
>
{isVideoOff ? <VideoOff className="w-4 h-4 text-red-400" /> : <Video className="w-4 h-4 text-white" />}
</Button>
)}
Expand All @@ -768,6 +782,7 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini
size="icon"
className="h-9 w-9 hover:bg-white/10 rounded-full"
onClick={() => onMinimize && onMinimize(false)}
aria-label="Expand Call"
title="Expand"
>
<Maximize2 className="w-4 h-4 text-white" />
Expand All @@ -777,6 +792,8 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini
size="icon"
className="h-9 w-9 rounded-full bg-red-500 hover:bg-red-600 border border-red-400/20"
onClick={handleEndCall}
aria-label="End Call"
title="End Call"
>
<PhoneOff className="w-4 h-4" />
</Button>
Expand Down Expand Up @@ -853,6 +870,8 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini
if (onMinimize) onMinimize(true);
else setInternalIsMinimized(true);
}}
aria-label="Minimize Call"
title="Minimize"
>
<Minimize2 className="w-5 h-5" />
</Button>
Expand All @@ -868,6 +887,8 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini
showStats ? "bg-white text-black hover:bg-white/90" : "bg-black/40 text-white hover:bg-white/10"
)}
onClick={() => setShowStats(!showStats)}
aria-label="Show Network Stats"
title="Network Stats"
>
<Info className="w-5 h-5" />
</Button>
Expand Down Expand Up @@ -997,7 +1018,8 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini
: "bg-white/5 hover:bg-white/20"
)}
onClick={toggleMute}
title="Toggle Mute"
aria-label={isMuted ? "Unmute" : "Mute"}
title={isMuted ? "Unmute" : "Mute"}
>
{isMuted ? (
<MicOff className="w-4 h-4 sm:w-5 sm:h-5 md:w-6 md:h-6" />
Expand All @@ -1018,7 +1040,8 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini
: "bg-white/5 hover:bg-white/20"
)}
onClick={toggleVideo}
title="Toggle Camera"
aria-label={isVideoOff ? "Turn Camera On" : "Turn Camera Off"}
title={isVideoOff ? "Turn Camera On" : "Turn Camera Off"}
>
{isVideoOff ? (
<VideoOff className="w-4 h-4 sm:w-5 sm:h-5 md:w-6 md:h-6" />
Expand All @@ -1037,7 +1060,8 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini
: "bg-white/5 hover:bg-white/20"
)}
onClick={toggleScreenShare}
title="Share Screen"
aria-label={isScreenSharing ? "Stop Screen Share" : "Share Screen"}
title={isScreenSharing ? "Stop Screen Share" : "Share Screen"}
>
{isScreenSharing ? (
<MonitorOff className="w-4 h-4 sm:w-5 sm:h-5 md:w-6 md:h-6" />
Expand All @@ -1059,7 +1083,8 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini
: "bg-white/5 hover:bg-white/20"
)}
onClick={toggleANC}
title="Active Noise Cancellation"
aria-label={isANCEnabled ? "Disable Noise Cancellation" : "Enable Noise Cancellation"}
title={isANCEnabled ? "Disable Noise Cancellation" : "Enable Noise Cancellation"}
>
<Waves className="w-4 h-4 sm:w-5 sm:h-5 md:w-6 md:h-6" />
</Button>
Expand All @@ -1069,6 +1094,7 @@ export function CallOverlay({ friend, type, currentUser, isMinimized: propIsMini
size="icon"
className="h-12 w-12 sm:h-14 sm:w-14 md:h-16 md:w-16 shrink-0 rounded-full bg-rose-500 text-white hover:bg-rose-600 shadow-[0_4px_20px_rgba(244,63,94,0.4)] hover:scale-105 transition-all"
onClick={handleEndCall}
aria-label="End Call"
title="End Call"
>
<PhoneOff className="w-5 h-5 sm:w-6 sm:h-6 md:w-8 md:h-8" />
Expand Down
1 change: 1 addition & 0 deletions src/components/mobile-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export function MobileNav() {
<Link
key={item.href}
href={item.href}
aria-label={item.title}
className="relative flex flex-col items-center justify-center w-12 h-12 sm:w-14 sm:h-14 rounded-xl"
>
{/* Active Background Pill */}
Expand Down