Skip to content

fix(wallpaper): restore rendering and recover stored preferences - #6

Merged
viralcodex merged 1 commit into
mainfrom
fix-wallpaper-runtime
Nov 20, 2026
Merged

viralcodex merged 1 commit into
mainfrom
fix-wallpaper-runtime

Conversation

@viralcodex

Copy link
Copy Markdown
Owner

Summary

  • Migrate legacy wallpaper preferences at the storage boundary and use one current image list and appearance settings.
  • Watch native folder changes instead of polling, bound image reads, and use Effect permits for thumbnail concurrency.
  • Report folder and watcher failures, allow recovered errors to notify again, and release obsolete error deduplication state.
  • Keep owned styles attached to the document head so the wallpaper, gallery, and picker render correctly.
  • Label the picker toggle with its next action: "Turn wallpaper on" or "Turn wallpaper off".
  • Add native Node watcher regressions, real host-persistence checks, and Chromium checks for stylesheet application and rendered gallery-toggle accessibility. Rebuild the shipped GUI bundle.
  • Remove obsolete polling assertions and mocked GUI painting tests. Keep strict write validation and test legacy migration at the storage boundary.

Independent review

The independent review found four issues, all corrected before merging:

  • Invalid or missing preferences could discard uploads. Stored reads now recover fields independently, tested against OpenCode's actual persistence decoder.
  • Recreating a symlink target failed to restore the catalog under Node. Both the alias and resolved target parents now have watchers, with a native Node regression.
  • The SDK button dropped gallery disclosure attributes. The gallery toggle now uses a native button with plugin-owned styling, and Chromium checks its rendered attributes and click behavior.
  • The browser check depended on a pre-existing temporary directory. It now creates its parent directory and also passes with a fresh TMPDIR.

The browser check additionally runs the built GUI setup itself with real DOM styles and image decoding, rather than relying on a mocked style registry.
It uses Playwright with a sandboxed, isolated Chrome profile and real-time waits, not Chrome's artificial virtual-time clock.

Validation

  • bun run check
  • bun run test:styles
  • bun run test:storage <OpenCode checkout>
  • node --test .github/scripts/owner-approval.test.cjs
  • git diff --check

Scope

The local, untracked showcase/ project and media are not part of this PR.

Visual

<svg xmlns="http://www.w3.org/2000/svg" width="240" height="72" viewBox="0 0 240 72">
  <rect x="8" y="8" width="224" height="56" rx="8" fill="currentColor" opacity=".08"/>
  <g fill="currentColor" opacity=".5">
    <rect x="16" y="16" width="40" height="24" rx="3"/>
    <rect x="62" y="16" width="40" height="24" rx="3"/>
    <rect x="108" y="16" width="40" height="24" rx="3"/>
    <animate attributeName="opacity" values=".5;.75;.5" dur="3s" repeatCount="indefinite"/>
  </g>
  <text x="16" y="55" font-size="10" font-family="sans-serif" fill="currentColor">Turn wallpaper off</text>
</svg>

@viralcodex
viralcodex merged commit a267d52 into main Nov 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant