fix(ui): hero values fit their card; release 1.3.4 - #19
Merged
Conversation
…llapse on a phone
"Excellent" on the Data health card was set at the hero figure size, which is
tuned for numbers; the word is wider than one grid card at that size, so it
read "Excelle" with the rest cut off. The Cost hero ("$364.52") and the Peaks
hero ("53.3M") had the same defect on narrower windows.
A hero value is now sized to the column it sits in with container units,
between a readable floor (20px scaled by the theme) and the hero size: 19% of
the width fits the longest figure the formatters emit in the widest figure
font, 17% fits the longest grade. The grade card takes a double-width slot so
the word shows at full size on anything wider than a phone. The 860px rule
now lowers the cap instead of pinning the size, so it cannot reintroduce the
overflow.
The Overview's two-up chart grid asked for 420px columns, which pushed the page
64px past a 380px viewport; the minimum now yields to the available width. A
wide card falls back to one column below 480px, and branch names in the Live
receipts list wrap instead of spilling out of their column.
Verified by rendering all 21 views in the three themes at 1440, 1000, 700 and
380px and probing every card for text past its edge and the page for sideways
scroll: none remain.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
uses:tag moved to v1.3.4.Verified
All 21 views rendered headless in the three themes at 1440, 1000, 700 and 380px, every card probed for text past its edge and the page for sideways scroll: none remain. Lint, 841 tests, typecheck and the design gate pass locally.
🤖 Generated with Claude Code