Skip to content

fix unicode display - #96

Merged
viktomas merged 1 commit into
viktomas:mainfrom
kanlac:main
May 26, 2024
Merged

fix unicode display#96
viktomas merged 1 commit into
viktomas:mainfrom
kanlac:main

Conversation

@kanlac

@kanlac kanlac commented May 21, 2024

Copy link
Copy Markdown
Contributor
  • I've read Contribution guide
  • I've tested everything that doesn't relate to tcell.Screen API

Close #76.

Compared to adding extra blank runes (#77), I think a more reasonable way is to fix the implementation of GetCell.

@viktomas

Copy link
Copy Markdown
Owner

Thank you @kanlac 🙏

The implementation makes sense to me, can you please add to your PR description a test case that I can try with the current version and then with your PR to see this change in action?

Once I manually re-test this, the PR is good to go

@kanlac

kanlac commented May 26, 2024

Copy link
Copy Markdown
Contributor Author

Sure, it's easy to reproduce. You can create a file or directory with Unicode characters, for example mkdir 测试目录, and then run godu -l 0. You will see that the second and fourth characters are missing.
image

After this PR change, the file names will display correctly:
image

@viktomas

Copy link
Copy Markdown
Owner

Thank you @kanlac, I tested this locally, and it works well 👍

@viktomas
viktomas merged commit 54765d1 into viktomas:main May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unicode support

2 participants