Conversation
…ice, and repository layers
Implement location service with API and Docker setup
…ice, and repository layers
Reviewer's GuideIntroduces a new Spring Boot-based location-service microservice (cities and airports) wired to MySQL via docker-compose, including domain models, DTOs, mappers, repositories, services, REST controllers, and shared payload/embedded types in common-lib, while disabling unused cloud modules and swapping the services module to location-service. Sequence diagram for creating an airport (sequence)sequenceDiagram
actor Client
participant AirportController
participant AirportServiceimpl
participant CityRepository
participant AirportRepository
participant MySQL
Client->>AirportController: POST /api/v1/airports\nAirportRequest
AirportController->>AirportServiceimpl: createAirport(request)
AirportServiceimpl->>CityRepository: findById(request.cityId)
CityRepository->>MySQL: SELECT city by id
MySQL-->>CityRepository: City
CityRepository-->>AirportServiceimpl: City
AirportServiceimpl->>AirportRepository: existsByIataIgnoreCase(request.iata)
AirportRepository->>MySQL: SELECT count by iata
MySQL-->>AirportRepository: exists?
AirportRepository-->>AirportServiceimpl: boolean
AirportServiceimpl->>AirportServiceimpl: AirportMapper.toEntity(request)
AirportServiceimpl->>AirportRepository: save(airport)
AirportRepository->>MySQL: INSERT airport
MySQL-->>AirportRepository: persisted Airport
AirportRepository-->>AirportServiceimpl: Airport
AirportServiceimpl->>AirportServiceimpl: AirportMapper.toDto(airport)
AirportServiceimpl-->>AirportController: AirportResponse
AirportController-->>Client: 201 Created\nApiResponse<AirportResponse>
ER diagram for City and Airport tables (entity_relationship)erDiagram
CITY {
BIGINT id PK
VARCHAR name
VARCHAR country_code
VARCHAR country
VARCHAR city_code
VARCHAR region_code
VARCHAR time_zone_id
}
AIRPORTS {
BIGINT id PK
VARCHAR iata
VARCHAR name
VARCHAR time_zone_id
VARCHAR address_street
VARCHAR address_postal_code
DOUBLE geo_latitude
DOUBLE geo_longitude
BIGINT city_id FK
}
CITY ||--o{ AIRPORTS : has
Class diagram for location-service domain, DTOs, services, and controllers (class)classDiagram
%% DOMAIN MODELS
class City {
Long id
String name
String countryCode
String country
String cityCode
String regionCode
String timeZoneId
}
class Airport {
Long id
String iata
String name
String timeZone
Address address
GeoCode geoCode
+String getDetailName()
}
class Address {
String street
String postalCode
}
class GeoCode {
Double latitude
Double longitude
}
City "1" o-- "*" Airport : airports
Airport "*" --> "1" City : city
Airport o-- Address
Airport o-- GeoCode
%% REQUEST DTOs
class CityRequest {
String name
String countryCode
String country
String cityCode
String regionCode
String timeZoneOffset
}
class AirportRequest {
String iata
String name
String timeZoneId
Address address
GeoCode geoCode
Long cityId
}
%% RESPONSE DTOs
class CityResponse {
Long id
String name
String countryCode
String country
String cityCode
String regionCode
String timeZoneOffest
}
class AirportResponse {
Long id
String iata
String name
String timeZoneId
Address address
GeoCode geoCode
CityResponse city
}
class ApiResponse~T~ {
boolean success
String message
T data
LocalDateTime timestamp
+success(data T) ApiResponse~T~
+success(message String, data T) ApiResponse~T~
}
ApiResponse --> CityResponse
ApiResponse --> AirportResponse
%% REPOSITORIES
class CityRepository {
+Page~City~ findByCountryCodeIgnoreCase(countryCode String, pageable Pageable)
+boolean existsByCityCodeIgnoreCase(cityCode String)
+Page~City~ searchByKeyword(keyword String, pageable Pageable)
}
class AirportRepository {
+boolean existsByIataIgnoreCase(iata String)
+boolean existsByIataIgnoreCaseAndIdNot(iata String, id Long)
+List~Airport~ findByCityId(cityId Long)
+boolean existsByCityId(cityId Long)
}
CityRepository ..|> JpaRepository
AirportRepository ..|> JpaRepository
%% SERVICES
class CityService {
+CityResponse createCity(cityRequest CityRequest)
+CityResponse updateCity(id Long, cityRequest CityRequest)
+CityResponse getCityById(id Long)
+void deleteCity(id Long)
+Page~CityResponse~ getAllCities(pageable Pageable)
+Page~CityResponse~ searchCities(keyword String, pageable Pageable)
+Page~CityResponse~ getCitiesByCountryCode(countryCode String, pageable Pageable)
+boolean cityExists(cityCode String)
}
class CityServiceImpl {
-CityRepository cityRepository
+CityResponse createCity(cityRequest CityRequest)
+CityResponse updateCity(id Long, cityRequest CityRequest)
+CityResponse getCityById(id Long)
+void deleteCity(id Long)
+Page~CityResponse~ getAllCities(pageable Pageable)
+Page~CityResponse~ searchCities(keyword String, pageable Pageable)
+Page~CityResponse~ getCitiesByCountryCode(countryCode String, pageable Pageable)
+boolean cityExists(cityCode String)
}
CityServiceImpl ..|> CityService
CityServiceImpl --> CityRepository
class AirportService {
+AirportResponse createAirport(request AirportRequest)
+AirportResponse updateAirport(id Long, request AirportRequest)
+List~AirportResponse~ getAllAirports()
+AirportResponse getAirportById(id Long)
+void deleteAirport(id Long)
+List~AirportResponse~ getAirportsByCityId(cityId Long)
}
class AirportServiceimpl {
-AirportRepository airportRepository
-CityRepository cityRepository
-CityService cityService
+AirportResponse createAirport(request AirportRequest)
+AirportResponse updateAirport(id Long, request AirportRequest)
+List~AirportResponse~ getAllAirports()
+AirportResponse getAirportById(id Long)
+void deleteAirport(id Long)
+List~AirportResponse~ getAirportsByCityId(cityId Long)
}
AirportServiceimpl ..|> AirportService
AirportServiceimpl --> AirportRepository
AirportServiceimpl --> CityRepository
AirportServiceimpl --> CityService
%% MAPPERS
class CityMapper {
+City toEntity(request CityRequest)
+CityResponse toDto(city City)
+void updateEntityFromRequest(request CityRequest, city City)
}
class AirportMapper {
-CityMapper cityMapper
+Airport toEntity(request AirportRequest)
+AirportResponse toDto(airport Airport)
+void updateEntityFromRequest(request AirportRequest, airport Airport)
}
CityMapper --> City
CityMapper --> CityRequest
CityMapper --> CityResponse
AirportMapper --> Airport
AirportMapper --> AirportRequest
AirportMapper --> AirportResponse
AirportMapper --> CityMapper
%% CONTROLLERS
class CityController {
-CityService cityService
+ResponseEntity~ApiResponse~ createCity(cityRequest CityRequest)
+ResponseEntity~ApiResponse~ updateCity(id Long, cityRequest CityRequest)
+ResponseEntity~ApiResponse~ getCityById(id Long)
+ResponseEntity~Void~ deleteCity(id Long)
+ResponseEntity~ApiResponse~ getAllCities(pageable Pageable)
+ResponseEntity~ApiResponse~ searchCities(keyword String, pageable Pageable)
+ResponseEntity~ApiResponse~ getCitiesByCountryCode(countryCode String, pageable Pageable)
+ResponseEntity~ApiResponse~ cityExists(cityCode String)
}
class AirportController {
-AirportService airportService
+ResponseEntity~ApiResponse~ createAirport(request AirportRequest)
+ResponseEntity~ApiResponse~ updateAirport(id Long, request AirportRequest)
+ResponseEntity~ApiResponse~ getAirportById(id Long)
+ResponseEntity~ApiResponse~ getAllAirports()
+ResponseEntity~Void~ deleteAirport(id Long)
+ResponseEntity~ApiResponse~ getAirportsByCityId(cityId Long)
}
class HomeController {
+String HomeController()
}
CityController --> CityService
AirportController --> AirportService
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The
AirportMapperandCityMapperclasses mix static methods with an injected dependency (CityMapperinAirportMapper), which is both unused and inconsistent with their static API; either make these mappers fully static utility classes (no Spring component/dependency) or fully instance-based beans without static methods. - The service implementation class
AirportServiceimplis mis-capitalized and lives in aRepositorypackage with a capital "R" in imports (com.flynest.location_service.Repository), which is inconsistent with Java/Spring naming conventions and may cause confusion; consider renaming toAirportServiceImpland normalizing package names to lowercase (e.g.repository). - This PR includes IDE and build artifacts (e.g.
.idea/*,common-lib/target/...); these should generally be excluded via.gitignoreand removed from the repository to keep the VCS clean.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `AirportMapper` and `CityMapper` classes mix static methods with an injected dependency (`CityMapper` in `AirportMapper`), which is both unused and inconsistent with their static API; either make these mappers fully static utility classes (no Spring component/dependency) or fully instance-based beans without static methods.
- The service implementation class `AirportServiceimpl` is mis-capitalized and lives in a `Repository` package with a capital "R" in imports (`com.flynest.location_service.Repository`), which is inconsistent with Java/Spring naming conventions and may cause confusion; consider renaming to `AirportServiceImpl` and normalizing package names to lowercase (e.g. `repository`).
- This PR includes IDE and build artifacts (e.g. `.idea/*`, `common-lib/target/...`); these should generally be excluded via `.gitignore` and removed from the repository to keep the VCS clean.
## Individual Comments
### Comment 1
<location path="services/location-service/src/main/java/com/flynest/location_service/model/Airport.java" line_range="39-44" />
<code_context>
+ private com.flynest.emabbedable.GeoCode geoCode;
+
+ @ManyToOne(fetch = FetchType.LAZY)
+ @JsonIgnore
+ @JoinColumn(name = "city_id", nullable = false)
+ private City city;
+
+ @JsonIgnore
+ @Transient
+ public String getDetailName(){
+ if(city != null && city.getCityCode() != null){
</code_context>
<issue_to_address>
**issue (bug_risk):** Use the JPA @Transient annotation instead of java.beans.Transient for getDetailName().
`java.beans.Transient` is only used by the JavaBeans introspector and is ignored by JPA. Replace it with `jakarta.persistence.Transient` so `getDetailName()` is treated as a non-persistent computed property. Keep `@JsonIgnore` if you also want it excluded from JSON serialization.
</issue_to_address>
### Comment 2
<location path="services/location-service/readme.md" line_range="43-47" />
<code_context>
+- cache ttl
+
+
+### Bulk Operations
+- Importing all airport of India
+ - POST: api/airports/bulk
+ - POST: api/cities/bulk
+- Validation failure
+
+### Dto & Mappeer Pattern
</code_context>
<issue_to_address>
**nitpick (typo):** Correct pluralization in the bulk operations description.
"Importing all airport of India" should be updated to "Importing all airports of India" or "Importing all airports in India" for more natural phrasing.
```suggestion
### Bulk Operations
- Importing all airports in India
- POST: api/airports/bulk
- POST: api/cities/bulk
- Validation failure
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+39
to
+44
| @JsonIgnore | ||
| @JoinColumn(name = "city_id", nullable = false) | ||
| private City city; | ||
|
|
||
| @JsonIgnore | ||
| @Transient |
There was a problem hiding this comment.
issue (bug_risk): Use the JPA @transient annotation instead of java.beans.Transient for getDetailName().
java.beans.Transient is only used by the JavaBeans introspector and is ignored by JPA. Replace it with jakarta.persistence.Transient so getDetailName() is treated as a non-persistent computed property. Keep @JsonIgnore if you also want it excluded from JSON serialization.
Comment on lines
+43
to
+47
| ### Bulk Operations | ||
| - Importing all airport of India | ||
| - POST: api/airports/bulk | ||
| - POST: api/cities/bulk | ||
| - Validation failure |
There was a problem hiding this comment.
nitpick (typo): Correct pluralization in the bulk operations description.
"Importing all airport of India" should be updated to "Importing all airports of India" or "Importing all airports in India" for more natural phrasing.
Suggested change
| ### Bulk Operations | |
| - Importing all airport of India | |
| - POST: api/airports/bulk | |
| - POST: api/cities/bulk | |
| - Validation failure | |
| ### Bulk Operations | |
| - Importing all airports in India | |
| - POST: api/airports/bulk | |
| - POST: api/cities/bulk | |
| - Validation failure |
…gin functionality
…rofile management
TEST#2 : UserServuice with Authentication and authorization
# Conflicts: # .idea/workspace.xml
…and mapper layers; add application configuration and Maven wrapper
Feat: Airline and AirCraft Services
…nfiguration, Maven wrapper, and essential files
… request/response models
…flight scheduling
…tegrate Flight entity and enhance schedule creation
Flight Operation service having flight instance and schedules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REQ:
Summary by Sourcery
Introduce a new Spring Boot-based location-service with MySQL-backed city and airport management APIs, wiring it into the services module and local Docker-based MySQL configuration.
New Features:
Enhancements: