feat:(ProgressBar) Improved Current Progress Bar Time Readability for Screen Readers#8985
Open
damanV5 wants to merge 1 commit intovideojs:mainfrom
Open
feat:(ProgressBar) Improved Current Progress Bar Time Readability for Screen Readers#8985damanV5 wants to merge 1 commit intovideojs:mainfrom
damanV5 wants to merge 1 commit intovideojs:mainfrom
Conversation
Contributor
Author
|
@mister-ben @gkatsev |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8985 +/- ##
==========================================
+ Coverage 84.13% 84.19% +0.06%
==========================================
Files 120 121 +1
Lines 8117 8180 +63
Branches 1948 1961 +13
==========================================
+ Hits 6829 6887 +58
- Misses 1288 1293 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new component inside
SeekBarto support human understandable time by screen-readers.If seek bar is at 0:20/14:05, then screen reader will announce 'twenty seconds of 14 minutes, 5 seconds.
Specific Changes proposed
progress-time-display.jsinsideSeekbar.js.Intl_PluralRulesapi to format numbers according to pluralization rules for different languages.aria-valuetext. This was being read by the screen reader.For Localisation , time_units would be defined for specific languages:-
"time_units": {
"hour": { "one": "hour", "other": "hours" },
"minute": { "one": "minute", "other": "minutes" },
"second": { "one": "second", "other": "seconds" }
}
Here,
one means :
singular value of that unitother mean :
plural value of that unitRequirements Checklist
npm run docs:apito error