Repository navigation
docs(releasing): the pre-release cargo test needs TRUFFLE_SIDECAR_SKIP_DOWNLOAD=1 on a release branch - #194
Merged
Merged
Conversation
…P_DOWNLOAD=1 on a release branch Running the documented list verbatim on the 0.7.14 release branch: every line green except `cargo test --locked --workspace`, which panics in truffle-sidecar's build script — "SECURITY: no pinned checksum for 0.7.14/…" — because the checksum for the version under release cannot exist before its tag. That is the fail-closed contract working; CI sets TRUFFLE_SIDECAR_SKIP_DOWNLOAD=1 for exactly this reason (ci.yml), and the clippy line already carried it. The test line now carries it too, with the why. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EKZYYSoZPAXbaw1CYULNKW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while releasing 0.7.14: the documented
cargo test --locked --workspacepanics on a release branch in truffle-sidecar's build script (no pinned checksum for the version under release — by design). CI setsTRUFFLE_SIDECAR_SKIP_DOWNLOAD=1; the doc line now does too, with the reason. Merge after the 0.7.14 release finishes.🤖 Generated with Claude Code
https://claude.ai/code/session_01EKZYYSoZPAXbaw1CYULNKW
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.