Add builder field#856
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for specifying a target builder when starting a reload build and provides feedback if a fallback builder is used. The changes update both the protobuf definitions and the generated JavaScript code to handle the new
builderandbuilder_fallback_messagefields.Protobuf schema changes:
builderfield to theStartReloadBuildRequestmessage, allowing clients to specify which builder to use (e.g., to target the new Viam build service).builder_fallback_messagefield to theStartReloadBuildResponsemessage, which is present if the requested builder was unavailable and the default builder was used instead.Generated JavaScript (
build_pb.js) updates:StartReloadBuildRequest:builderfield in object serialization, deserialization, and binary wire format methods. Added getter, setter, clear, and presence-check methods forbuilder. [1] [2] [3] [4]StartReloadBuildResponse:builder_fallback_messagefield in object serialization, deserialization, and binary wire format methods. Added getter, setter, clear, and presence-check methods forbuilder_fallback_message. [1] [2] [3] [4]