Skip to content

Add builder field#856

Merged
amaschas merged 3 commits into
mainfrom
adding-builder-field-to-reload
May 20, 2026
Merged

Add builder field#856
amaschas merged 3 commits into
mainfrom
adding-builder-field-to-reload

Conversation

@amaschas
Copy link
Copy Markdown
Member

This pull request adds support for specifying a target builder when starting a reload build and provides feedback if a fallback builder is used. The changes update both the protobuf definitions and the generated JavaScript code to handle the new builder and builder_fallback_message fields.

Protobuf schema changes:

  • Added an optional builder field to the StartReloadBuildRequest message, allowing clients to specify which builder to use (e.g., to target the new Viam build service).
  • Added an optional builder_fallback_message field to the StartReloadBuildResponse message, which is present if the requested builder was unavailable and the default builder was used instead.

Generated JavaScript (build_pb.js) updates:

  • Updated StartReloadBuildRequest:
    • Included the new builder field in object serialization, deserialization, and binary wire format methods. Added getter, setter, clear, and presence-check methods for builder. [1] [2] [3] [4]
  • Updated StartReloadBuildResponse:
    • Included the new builder_fallback_message field in object serialization, deserialization, and binary wire format methods. Added getter, setter, clear, and presence-check methods for builder_fallback_message. [1] [2] [3] [4]

@github-actions github-actions Bot added the safe to test committer is a member of this org label May 19, 2026
@amaschas amaschas requested a review from cecilyViam May 19, 2026 20:36
Copy link
Copy Markdown
Member

@cecilyViam cecilyViam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@amaschas amaschas added the ready-for-protos add this when you want protos to compile on every commit label May 19, 2026
@amaschas amaschas merged commit 14f9006 into main May 20, 2026
10 of 12 checks passed
@amaschas amaschas deleted the adding-builder-field-to-reload branch May 20, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

protos-compiled ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants