Keep include flags in their own lane so they have a consistent order#4966
Open
adamnovak wants to merge 1 commit into
Open
Keep include flags in their own lane so they have a consistent order#4966adamnovak wants to merge 1 commit into
adamnovak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
We weren't consistently keeping our include flags in One True List, and the Homebrew ones could get ahead of the ones for vg's vendored dependency install directory. This fixes that.
Now we have
CPPFLAGSfor all the compiler flags (except-Dflags that come in from pkg-config), andINCLUDE_FLAGSfor all the include directories.