Repository navigation
Require PHP 8.5.12 - #24
Merged
Merged
Conversation
Require PHP 8.5.12, run CI on that release, and base the dev image on the official 8.5.12 CLI image. Mark nullable parameters explicitly and drop ReflectionMethod::setAccessible(), which PHP 8.5 deprecates. Co-authored-by: Alejandro Uribe Sánchez <alejouribesanchez@gmail.com>
alejouribesanchez
marked this pull request as ready for review
October 22, 2026 16:23
decim92
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the PHP SDK onto PHP 8.5.12, the current 8.5 security release.
php: >=8.5.12. The README badge and API coverage note match that minimum.8.5.12and publish coverage badges from that job.php:8.5.12-cli-bookwormwith Xdebug 3.5.3. The image build checks thatPHP_VERSIONis exactly8.5.12and that curl, mbstring, fileinfo, dom, and Xdebug are loaded.Type $name = null) are now explicit (?Type $name = null). Call sites are unchanged.tests/ClientCoverageTest.phpno longer callsReflectionMethod::setAccessible(), which PHP 8.5 deprecates.Test plan
composer validate --stricton PHP 8.5.12./vendor/bin/phpunit --display-all-issueson PHP 8.5.12 with Xdebug 3.5.3: 179 tests, 676 assertions, no deprecations8.5.12viashivammathur/setup-phpphp:8.5.12-cli-bookworm) was not run in this environment (no Docker daemon)Slack Thread