Fix stats.countby --by-name sort with mixed value types (SYN-9957)

[invisig0th]

SYN-9957

stats.countby --by-name leaked a raw python TypeError whenever a tally contained a mix of numeric and non-numeric names. Reported by a Sentinel 1 user via epiphyte.

cli> storm inet:ipv4 stats.countby --by-name :asn
ERROR: TypeError: '<' not supported between instances of 'str' and 'int'

The --by-name sort key returned int() for names which parsed as integers and the original str for names which did not, so a tally containing both handed sorted() a non-orderable mix of types. The common trigger is nodes which do not have the tallied property set, since those tally under the name None.

Changes

Numeric names now sort numerically and non-numeric names sort lexicographically after them, via a type-homogeneous sort key.

s_common.hugenum() is used in place of int(), so fractional names sort numerically too (1, 1.5, 2, 10) with exact decimal comparison and none of the float() rounding fuzz. Two cases are handled explicitly:

• hugenum('0xzz') raises ValueError from its hex branch rather than a DecimalException
• hugenum('nan') succeeds, but Decimal('NaN') < Decimal(1) raises InvalidOperation — the same leak class being fixed — so non-finite values are treated as non-numeric

The coerce(indx) closure factory was only ever called as coerce(0), so the unused indx generality is dropped.

Before / After

cli> storm inet:ipv4 stats.countby --by-name :asn      # after
None | 1 | #########################
   4 | 1 | #########################
   1 | 2 | ##################################################
   0 | 1 | #########################

Tests

The regression assertions are appended to the existing test_stormlib_stats_countby so they reuse the Cortex it already stands up rather than booting a second one. The new inet:ipv4 nodes are tagged and lifted by tag, so the existing 15-node fixture and its 18 chart expectations are unaffected.

Coverage:

• the reported unset-property tally, in both directions
• a mixed tally covering finite decimals, fractions, hex names, the ValueError arm, the non-finite arm, and plain strings

Passes plain and under SYNDEV_NEXUS_REPLAY=1. 100% patch coverage — synapse/lib/stormlib/stats.py reports 99% with the only miss on StatTally.value(), which is pre-existing and outside this diff.

No docs change: storm_ref_cmd.rstorm renders stats.countby --help dynamically and no option help text changed.

Note on 3.x

synsrc/synapse/lib/stormlib/stats.py in synapse-enterprise carries a byte-identical copy of the buggy if byname: block, and the failure reproduces there as inet:ip | stats.countby :asn --by-name. That needs a separate PR against main; the fix transplants verbatim, but the charts differ because v3 renders the percent column unconditionally instead of behind --percent.

https://claude.ai/code/session_013pyj3S8NddfycqDWj9uBUS

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (7736fb2) to head (fba0a5d).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5017      +/-   ##
==========================================
- Coverage   97.89%   97.83%   -0.06%     
==========================================
  Files         308      308              
  Lines       65689    65690       +1     
==========================================
- Hits        64305    64270      -35     
- Misses       1384     1420      +36     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.