SAS app health check retry#418
Merged
Merged
Conversation
Retry for sas app health check up to 60 seconds. It may not be in healthy state yet right after devcontainer service completes
yonghaoy
approved these changes
May 21, 2026
Contributor
|
A data point, I wait for few minutes until SAS get health after startup script... |
Contributor
Author
Hm, maybe I need to bump the retry count. I'll bump to 5 minutes |
Contributor
Author
|
Tested out change, took ~1 minute for status to change from "UNHEALTHY" to "HEALTHY" |
Contributor
Author
|
Ignore failures, they are due to image being too large, should be fixed separately |
michaelxiao7
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry for sas app health check up to 60 seconds. It may not be in healthy state yet right after devcontainer service completes