Add health check for SAS app readiness#415
Merged
Merged
Conversation
The readiness probe (probe-proxy-readiness.sh) only checks if docker containers are running, but SAS Studio takes ~40s to initialize inside the container. This causes the UI to show "Running" while the app returns 503. Add a Docker HEALTHCHECK to the SAS Dockerfile that polls SAS Studio on port 7080, and update the readiness probe to wait for "healthy" status before marking startup_script/status=COMPLETE. Containers without a HEALTHCHECK (status "none") pass through unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
june-hua
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HEALTHCHECKto the SAS Dockerfile that pollshttp://localhost:7080/SASStudio/(5s interval, 60s start period)probe-proxy-readiness.shto check container health status — requireshealthybefore markingstartup_script/status=COMPLETEHEALTHCHECK(health statusnone) are unaffectedProblem
The readiness probe only checks if docker containers are running, but SAS Studio takes ~40s to initialize inside the container. This causes the UI to show "Running" and enable the "Open" button while SAS Studio returns 503.
Test plan
nonepasses through)🤖 Generated with Claude Code
PHP-151121