Run context gen script as jupyter user#414
Conversation
|
Confirmed that fix works: |
| ], | ||
| // re-mount bucket files on container start up, then generate LLM context | ||
| "postStartCommand": "./startupscript/remount-on-restart.sh jupyter /home/jupyter \"${templateOption:cloud}\" \"${templateOption:login}\"; /opt/llm-context/run-context-generator.sh /home/jupyter || true", | ||
| "postStartCommand": "./startupscript/remount-on-restart.sh jupyter /home/jupyter \"${templateOption:cloud}\" \"${templateOption:login}\"; sudo -u jupyter /opt/llm-context/run-context-generator.sh /home/jupyter || true", |
There was a problem hiding this comment.
No need to change the direction now. but more of a long term comment.
I think we should have added a dependency for that llm-feature on wb tools so devcontainer run/install that after wb tools so the wb is installed and also then in the ideal world have this generator run in the scripts within that feature and not here. So as an app author I would only need to include that feature in the "features" section and not additional commands here.
There was a problem hiding this comment.
For the wb CLI dependency, workbench-tools feature does not install it. It gets installed in postCreateCommand post-startup.sh.
We might consider moving that to workbench-tools in the future.
I also see that the context generation script is run on each devcontainer startup, curious if it only needs to be once on creation.
june-hua
force-pushed
the
june/fix-workbench-ai-context-gen
branch
from
4afa5ab to
60a5be6
Compare
3 participants
The context gen script was failing because
wbwas not setup. The CLI is only setup for jupyter user, so run script as the user.