-
Notifications
You must be signed in to change notification settings - Fork 341
Add opt-in QuickJS WASM VM engine (WORKFLOW_VM=quickjs) #3048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
db2ea8b
Add opt-in QuickJS WASM VM engine (WORKFLOW_VM=quickjs) with full eve…
TooTallNate a554718
QuickJS engine: AbortController, setAttributes, terminal drain, turbo…
TooTallNate 5f1d844
QuickJS engine: hook.getConflict support, cross-run writable forwardi…
TooTallNate d009b85
QuickJS engine: stream framing round-trip, bound step proxies, webhoo…
TooTallNate ef9a413
Apply biome fixes to QuickJS engine files
TooTallNate 5312c44
Address review feedback: anchor source-map strip to end-of-input, use…
TooTallNate f021cb0
CI: include generated QuickJS source assets in shared e2e build artif…
TooTallNate 17fbf32
Fix same-token hook ordering and conflicted-hook disposal in the Quic…
TooTallNate 7e0ea84
CI: run both VM engines across all frameworks and worlds; label jobs …
TooTallNate 842bfba
Fix stack overflow stripping inline source maps from webpack dev bund…
TooTallNate 8f086f7
e2e: poll step listings until analytics rows include attempt (optiona…
TooTallNate f2b386c
e2e: use --withData to force storage-backed step listings for attempt…
TooTallNate b0bf710
Sort imports in QuickJS serialization files (biome organizeImports)
TooTallNate 6e92ca3
QuickJS engine: resolve the run's full payload-key capability so seal…
TooTallNate b7bae0b
Address review: crypto/process parity, loud Intl guards, lazy engine …
TooTallNate 9716d0d
QuickJS engine: implement resilient resumeHook (hookInput materializa…
TooTallNate bd09d8c
Rerun CI
TooTallNate 0124196
QuickJS engine: split VM-local class/step-function reducers off the h…
TooTallNate 23cfd6c
QuickJS engine: enqueue explicit wait continuations instead of same-m…
TooTallNate a2a89d1
Merge remote-tracking branch 'origin/main' into quickjs-vm
TooTallNate 2375350
Sort imports in quickjs-entrypoint (biome organizeImports)
TooTallNate b1510ee
Merge remote-tracking branch 'origin/main' into quickjs-vm
TooTallNate 4eca96a
Address review: dispatch inside run-level try/catch, queue namespace …
TooTallNate f2bb56b
Sort imports in quickjs-runtime (biome organizeImports)
TooTallNate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@workflow/core': patch | ||
| 'workflow': patch | ||
| --- | ||
|
|
||
| QuickJS engine performance: cache compiled WebAssembly modules process-wide, and execute steps inline in a live-VM continuation loop (no queue round-trip per step, cheap events fed before step bodies, delayed wait-continuation dispatch for racing timers). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@workflow/core': minor | ||
| 'workflow': minor | ||
| --- | ||
|
|
||
| Add an experimental QuickJS WASM VM engine for workflow execution, opt-in via `WORKFLOW_VM=quickjs` (or per-run `executionContext.workflowVm`). The engine performs the same full event replay as the default `node:vm` engine but runs workflow code in a QuickJS VM compiled to WebAssembly, enabling platforms without `node:vm` support and laying the groundwork for VM-memory snapshotting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,9 @@ | ||
| # Auto-generated version file | ||
| src/version.ts | ||
|
|
||
| # Auto-generated quickjs-wasi binary assets (base64-encoded WASM + .so files) | ||
| src/runtime/quickjs-assets.generated.ts | ||
|
|
||
| # Auto-generated VM serde bundle (devalue + format-prefix + reducers, | ||
| # packaged as an ES-module string for evaluation inside the QuickJS VM) | ||
| src/runtime/vm-serde-bundle.generated.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A performance improvement to the change that is in the same PR shouldn't get a separate changeset