fix(eve): prioritize current hook deliveries over stale backlog - #1402
Open
iroiro147 wants to merge 2 commits into
Open
fix(eve): prioritize current hook deliveries over stale backlog#1402iroiro147 wants to merge 2 commits into
iroiro147 wants to merge 2 commits into
Conversation
Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
Contributor
|
@iroiro147 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #598. Rebuilt on current
main(46c6ce3); the old branch had diverged with no shared merge-base, so this is a fresh rebased replacement carrying the identical fix.What changed
Prioritize current hook deliveries over a stale backlog:
workflow-entry.tsnow buffers per-session hook deliveries via aDeliveryBuffersmodel so the most recent delivery wins and superseded turns are dropped instead of replayed LIFO. This was a semantic merge, not a textual one — the cherry-pick reconciled the PR'sDeliveryBuffersmodel with all upstream-newer behavior (session-timeout viaconsumeSessionTimeout/DEFAULT_SESSION_TIMEOUT_MS, cancellation viasettleCancelledTurnStep/cancelDescendantTurnsStep,DurableCompiledArtifactsSource, deferredDispatchedTurndisposal,runTurn).session-delivery-hook.tsre-addedconsumeSessionTimeout()so session-timeout detection and the new current/replaced prioritization coexist.Test evidence
pnpm --filter eve typecheckEnv-only note:
test/bin-bootstrap.test.ts(4 failures) fails only because the sandbox Node is v22.22.3 < the>=24required bybin/eve.js. This is pre-existing and path-disjoint from this PR (bin/eve.jsuntouched).