Skip to content

fix(eve): prioritize current hook deliveries over stale backlog - #1402

Open
iroiro147 wants to merge 2 commits into
vercel:mainfrom
iroiro147:fix/drop-stale-buffered-deliveries-547-rebased
Open

fix(eve): prioritize current hook deliveries over stale backlog#1402
iroiro147 wants to merge 2 commits into
vercel:mainfrom
iroiro147:fix/drop-stale-buffered-deliveries-547-rebased

Conversation

@iroiro147

Copy link
Copy Markdown
Contributor

Supersedes #598. Rebuilt on current main (46c6ce3); the old branch had diverged with no shared merge-base, so this is a fresh rebased replacement carrying the identical fix.

What changed

Prioritize current hook deliveries over a stale backlog: workflow-entry.ts now buffers per-session hook deliveries via a DeliveryBuffers model so the most recent delivery wins and superseded turns are dropped instead of replayed LIFO. This was a semantic merge, not a textual one — the cherry-pick reconciled the PR's DeliveryBuffers model with all upstream-newer behavior (session-timeout via consumeSessionTimeout/DEFAULT_SESSION_TIMEOUT_MS, cancellation via settleCancelledTurnStep/cancelDescendantTurnsStep, DurableCompiledArtifactsSource, deferred DispatchedTurn disposal, runTurn). session-delivery-hook.ts re-added consumeSessionTimeout() so session-timeout detection and the new current/replaced prioritization coexist.

Test evidence

Suite Result
pnpm --filter eve typecheck exit 0
unit src/execution + src/internal 131 files / 1127 tests PASS
unit workflow-entry / session-delivery-hook / turn-control-receiver / turn-dispatch 4 files / 39 tests PASS
integration session-delivery-hook.integration 2 tests PASS
lint (oxlint changed src files) clean
full-eve unit suite 535 files / 5651 passed (+1 skipped)

Env-only note: test/bin-bootstrap.test.ts (4 failures) fails only because the sandbox Node is v22.22.3 < the >=24 required by bin/eve.js. This is pre-existing and path-disjoint from this PR (bin/eve.js untouched).

Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@iroiro147 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant