fix: file name parsing#47
Open
vaguue wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Changed routes:Commit fe2beb4 (https://avatar-6d1njtsm4.vercel.sh). |
Member
|
This doesn't seem to work. All of these return png https://avatar-git-fork-vaguue-master.vercel.sh/username.svg |
styfle
reviewed
Oct 1, 2024
| const text = url.searchParams.get("text"); | ||
| const size = Number(url.searchParams.get("size") || "120"); | ||
| const [username, type] = name?.split(".") || []; | ||
| const { 0: username, length, [length - 1]: type }: { length: number, [key: number]: string } = name?.split(".") || []; |
Member
There was a problem hiding this comment.
Suggested change
| const { 0: username, length, [length - 1]: type }: { length: number, [key: number]: string } = name?.split(".") || []; | |
| const lastDot = name?.lastIndexOf("."); | |
| const username = name?.slice(0, lastDot); | |
| const type = name?.slice(lastDot + 1); |
Let's try this so that all the other dots are included in the username.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I have observed an unusual behavior with avatar.vercel.sh. The service only provides users with PNG files, even when .svg is specified at the end of the filename. While attempting to find a potential bug, I discovered another minor issue during my code review: if someone requests https://avatar.vercel.sh/username.svg.png, the service responds with an SVG file, which is not quite accurate. I have corrected this issue.
Best regards,
Vaguue.