Skip to content

fix(compiler): cap rendered diagnostics to avoid RangeError on large reports #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
techfreaque wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

fix(compiler): cap rendered diagnostics to avoid RangeError on large reports #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/compiler/src/diagnostics/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@ export function renderDiagnostic(
return out.join("\n");
}

// Above this many diagnostics, rendering every one (each carrying its own
// source-line context) can push the joined report past V8's max string
// length (RangeError: Invalid string length) — cap the render and say so,
// rather than crashing the whole report.
const MAX_RENDERED_DIAGNOSTICS = 1000;

export function renderAll(
diags: ScrDiagnostic[],
sourceTextByFile: Map<string, string>,
Expand All @@ -90,10 +96,15 @@ export function renderAll(
const sorted = [...diags].sort(
(a, b) => a.loc.file.localeCompare(b.loc.file) || a.loc.start - b.loc.start,
);
return sorted
const shown = sorted.slice(0, MAX_RENDERED_DIAGNOSTICS);
const rendered = shown
.map((d) => {
const text = sourceTextByFile.get(d.loc.file);
return renderDiagnostic(d, text === undefined ? undefined : { text }, opts);
})
.join("\n\n");
const omitted = sorted.length - shown.length;
return omitted > 0
? `${rendered}\n\n... ${omitted} more diagnostic${omitted === 1 ? "" : "s"} not shown (${sorted.length} total)`
: rendered;
}