Skip to content

Update CoSERV to rev 06#273

Merged
thomas-fossati merged 2 commits into
mainfrom
setrofim/coserv-06
Jun 11, 2026
Merged

Update CoSERV to rev 06#273
thomas-fossati merged 2 commits into
mainfrom
setrofim/coserv-06

Conversation

@setrofim

@setrofim setrofim commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
  • Add RIM queries
  • Add endorsed values

Comment thread coserv/query.go
Comment thread coserv/query.go

@yogeshbdeshpande yogeshbdeshpande left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments!

@setrofim setrofim requested a review from yogeshbdeshpande June 9, 2026 16:19
Comment thread coserv/query.go Outdated

@yogeshbdeshpande yogeshbdeshpande left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor typo, LGTM!

setrofim added 2 commits June 9, 2026 17:29
- Add RimSelector to Query, allowing querying by CoRIM/CoSWID/CoMID ID.
  A valid query specifies either an environment selector (plus
  artifact/result types) or a RIM selector, but not both.
- Add RIMs to the result set. This is a CMW collection that gets
  populated based on the RIM selector in the query.

Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
Implement the endorsed-values group of the result-set, adding entries
for endorsed-triple-record's and
conditional-endorsement-triple-record's.

(note the corresponding artifact type in the query is already
implemented).

Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
@setrofim setrofim force-pushed the setrofim/coserv-06 branch from c4e6625 to ecd14b1 Compare June 9, 2026 16:30
Comment thread coserv/resultset.go

@thomas-fossati thomas-fossati left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thomas-fossati thomas-fossati merged commit 7ca6407 into main Jun 11, 2026
13 checks passed
@thomas-fossati thomas-fossati deleted the setrofim/coserv-06 branch June 11, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants