fix: pre-release hardening from the v0.7.0 review (#121) - #123
Conversation
The getting-started walkthrough and deploy/docker-compose.image.yml.example referenced VEKTRA_VERSION=0.6.1, a tag that was never published (INFRA-007 ships its first image at 0.7.0). Point operators at the tag this release actually publishes. Addresses CodeRabbit #121 (comment 3608554399). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Francesco Vadicamo <f.vadicamo@gmail.com>
Every positional argument after the second silently replaced NAMESPACE, so 'reindex.sh --cleanup 1 tenant-a tenant-b' would delete from tenant-b. Reject a third positional argument with a clear error instead. Addresses CodeRabbit #121 (comment 3608554401). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Francesco Vadicamo <f.vadicamo@gmail.com>
A provider returning fewer ids than requested still let the job reach status=completed, so an operator could switch the active version to an incomplete index. Raise when len(stored) != len(chunk_embeddings); run_reindex's handler marks the job failed with the message. Addresses CodeRabbit #121 (comment 3608554413). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Francesco Vadicamo <f.vadicamo@gmail.com>
cleanup_soft_deleted_task held one Postgres connection open across per-document vector-store delete calls (external network I/O), risking pool exhaustion on a large backlog. Split into two short-lived sessions with the external deletions in between; behaviour (skip-empty, per-doc error skip, final log) is unchanged. Addresses CodeRabbit #121 (comment 3608554417). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Francesco Vadicamo <f.vadicamo@gmail.com>
The precondition asserted found[total] > 0, which the shared fixture text could satisfy without the target document being indexed. Assert doomed_id is in the returned results, mirroring the post-delete check. Addresses CodeRabbit #121 (comment 3608554407). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Francesco Vadicamo <f.vadicamo@gmail.com>
fvadicamo
added
documentation
|
Warning Review limit reached
Next review available in: 21 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Records the nine minor CodeRabbit findings from the #121 release review that were deferred (test-strengthening plus two minor edges), and the one rejected on policy grounds (restoring removed VEKTRA_RERANK_TOP_K). The four Major items were fixed in this same PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Francesco Vadicamo <f.vadicamo@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Vektra version to 0.7.0, refactors positional argument handling in reindex.sh, improves an integration test assertion, and adds a chunk count verification check during reindexing. Additionally, it optimizes the soft-delete cleanup task in vektra-ingest by splitting database operations into two short-lived sessions to avoid holding a connection open during external network I/O. The reviewer recommended using the public get_session_factory() function instead of directly accessing the private _session_factory variable in both database sessions to maintain proper encapsulation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Release v0.7.0. New endpoints (documents/{id}/chunks, index-versions/{version} cleanup), REQ-010 error envelope at the document root, top_k bounds, Qdrant chunk-path correctness via the VectorStoreProvider Protocol, GHCR publish on tag (INFRA-007), and the storage-correctness / CI-integrity hardening.
- 81 commits since v0.6.0; CHANGELOG [0.7.0] - 2026-07-18; 8 components + runtime __version__ at 0.7.0
- Docs audited and aligned (config var count 59->66 + 2 vars documented; image examples 0.6.1->0.7.0)
- Pre-release review: 4 Major CodeRabbit findings fixed (#123); 9 minor deferred to DEBT-036; RERANK_TOP_K backward-compat request rejected on policy
- Excluded: PR #99 (TECH-005 eval, ground truth pending)
Tests: lint + unit green; integration (pgvector + qdrant) + NFR gates green
1 participant
What
Addresses the four Major production findings (plus the release-relevant doc) from CodeRabbit's review of the v0.7.0 release PR #121. All on already-merged code; verified against source before applying.
VEKTRA_VERSION=0.6.1(never published; INFRA-007 ships its first image at 0.7.0) →0.7.0reindex.shsilently overwroteNAMESPACEwith a 3rd positional arg (--cleanup 1 tenant-a tenant-bdeleted fromtenant-b) → now rejectedstatus=completedeven on a partial store write → raises whenlen(stored) != len(chunk_embeddings)(job marked failed)cleanup_soft_deleted_taskheld a Postgres connection open across per-doc vector-store network deletes → split into two short-lived sessionstotal > 0(fixture could satisfy it without the target doc) → assertsdoomed_idis in the resultsNot included (deliberately)
VEKTRA_RERANK_TOP_Kas a deprecated property (test_config.py) — contradicts DEBT-013's intent and the project's no-backward-compatibility policy.Testing
make lintgreen (ruff + mypy 77 files + import-linter 8/8)make testgreen (800 passed, 3 skipped); the integration test change runs in CI (deselected locally) and mirrors the existing post-delete result shapeWhy now
These feed the v0.7.0
develop -> mainrelease PR #121 before tagging.🤖 Generated with Claude Code