fix(control-plane): reload memories when search is cleared - #3681
Open
oldnicke wants to merge 1 commit into
Open
fix(control-plane): reload memories when search is cleared#3681oldnicke wants to merge 1 commit into
oldnicke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3670.
When a zero-result text search was cleared, the Memories view kept the stale zero-result response and incorrectly replaced the search UI with the unfiltered empty-bank state.
This change explicitly reloads the unfiltered graph when an active query is cleared, while preserving tag/scope filters. The empty-bank state is also deferred while that reload is in flight so the search controls remain visible.
Validation:
./scripts/hooks/lint.shnpx tsc --noEmitnpm test -- --run tests/lib/search-query.test.ts./.githooks/pre-commitThe full control-plane suite has one pre-existing date-sensitive failure in
tests/lib/relative-time.test.ts; 143 tests pass.