chore(vector-stream): remove semicolon lint allow - #26331
Queued
arfa79 wants to merge 1 commit into
Queued
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Low-risk, test-only lint cleanup that removes an obsolete suppression without changing behavior.
Pull request overview
Removes an obsolete Clippy lint suppression from a vector-stream unit test now that current Clippy versions accept the code without the historical workaround, aligning with the ongoing effort to eliminate unnecessary allow attributes.
Changes:
- Deleted
#[allow(clippy::semicolon_if_nothing_returned)]from theexpiration_queue_impl_keyed_timerTokio test. - Kept the test behavior unchanged while reducing lint suppression surface area.
File summaries
| File | Description |
|---|---|
lib/vector-stream/src/partitioned_batcher.rs |
Removes a no-longer-needed Clippy allow on the expiration queue keyed-timer test. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
thomasqueirozb
enabled auto-merge
September 9, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the obsolete
clippy::semicolon_if_nothing_returnedsuppression from the Vector Stream expiration queue test. Current Clippy accepts the test without the historical workaround.References
Related: #23659
Vector configuration
Not applicable; this is a test-only lint cleanup.
How did you test this PR?
cargo clippy --package vector-stream --all-targetscargo test --package vector-stream expiration_queue_impl_keyed_timercargo fmt --all -- --checkgit diff --checkDoes this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines
@vectordotdev/vectorto reach out to us regarding this PR.git merge origin masterandgit push.