Skip to content

chore(vector-stream): remove semicolon lint allow - #26331

Queued
arfa79 wants to merge 1 commit into
vectordotdev:masterfrom
arfa79:chore/vector-stream-semicolon-lint-allow
Queued

chore(vector-stream): remove semicolon lint allow#26331
arfa79 wants to merge 1 commit into
vectordotdev:masterfrom
arfa79:chore/vector-stream-semicolon-lint-allow

Conversation

@arfa79

@arfa79 arfa79 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove the obsolete clippy::semicolon_if_nothing_returned suppression from the Vector Stream expiration queue test. Current Clippy accepts the test without the historical workaround.

References

Related: #23659

Vector configuration

Not applicable; this is a test-only lint cleanup.

How did you test this PR?

  • cargo clippy --package vector-stream --all-targets
  • cargo test --package vector-stream expiration_queue_impl_keyed_timer
  • cargo fmt --all -- --check
  • git diff --check

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Before pushing, follow our pre-push guidance.
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.

@arfa79
arfa79 requested a review from a team as a code owner September 9, 2026 12:09
Copilot AI lite review requested due to automatic review settings September 9, 2026 12:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Low-risk, test-only lint cleanup that removes an obsolete suppression without changing behavior.

Pull request overview

Removes an obsolete Clippy lint suppression from a vector-stream unit test now that current Clippy versions accept the code without the historical workaround, aligning with the ongoing effort to eliminate unnecessary allow attributes.

Changes:

  • Deleted #[allow(clippy::semicolon_if_nothing_returned)] from the expiration_queue_impl_keyed_timer Tokio test.
  • Kept the test behavior unchanged while reducing lint suppression surface area.
File summaries
File Description
lib/vector-stream/src/partitioned_batcher.rs Removes a no-longer-needed Clippy allow on the expiration queue keyed-timer test.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 9, 2026

@thomasqueirozb thomasqueirozb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomasqueirozb
thomasqueirozb added this pull request to the merge queue Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants